Merge pull request #40 from Progmasoft/feature/log-google-failures

Log why a Google callback could not finish

1 files changed, 6 insertions, 7 deletions

diff --git a/apps/api/Program.cs b/apps/api/Program.cs
index 688fe7d..31b46a2 100644
--- a/apps/api/Program.cs
+++ b/apps/api/Program.cs
@@ -45,13 +45,12 @@ if (!string.IsNullOrWhiteSpace(googleClientId) && !string.IsNullOrWhiteSpace(goo
         options.SignInScheme = AccountEndpoints.ExternalCookieScheme;
         options.SaveTokens = false;
         // A callback that cannot finish (the visitor declined on Google, or the state cookie is missing or
-        // expired) would otherwise end in an unhandled 500. The sign-in page explains a failed Google sign-in.
-        options.Events.OnRemoteFailure = context =>
-        {
-            context.Response.Redirect("/login?google=failed");
-            context.HandleResponse();
-            return Task.CompletedTask;
-        };
+        // expired) would otherwise end in an unhandled 500. The cause is logged, and the sign-in page explains
+        // a failed Google sign-in.
+        options.Events.OnRemoteFailure = context => GoogleSignInFailure.HandleAsync(
+            context,
+            context.HttpContext.RequestServices.GetRequiredService<ILoggerFactory>()
+                .CreateLogger(typeof(GoogleSignInFailure)));
     });
 }
 builder.Services.AddProblemDetails();