Read-only mirrors. Development, issues and pull requests are on GitHub.

summaryrefslogtreecommitdiffhomepage
path: root/tests/TestScripts
diff options
context:
space:
mode:
authorMartin Hořeňovský2025-07-21 17:47:59 +0200
committerMartin Hořeňovský2025-07-21 21:50:47 +0200
commit10aef62f21e52e5cd73bf0dc6ac8be35fbc4a798 (patch)
tree6e3bae072a2a0ecbd31f3ec0aab7eac8d673c5af /tests/TestScripts
parent98b4bbb35efc3937b24e1de5559c974bd2578a14 (diff)
downloadcatch3-10aef62f21e52e5cd73bf0dc6ac8be35fbc4a798.tar.gz
Regularize scoped message lifetime to only consider the object's scope
This means that: 1) Scoped messages are always removed at the end of their scope, even if the scope ended due to an exception. 2) Scoped messages outlive section end, if that section's scope is enclosed in their own. Previously neither of these were true, which has led to a number of surprising behaviour, where e.g. this: ```cpp TEST_CASE() { try { INFO( "some info" ); throw std::runtime_error( "ex" ); } catch (std::exception const&) {} REQUIRE( false ); } ``` would print "some info" as the message for the assertion, while this: ```cpp TEST_CASE() { INFO("Hello"); SECTION("dummy") {} REQUIRE(false); } ``` would not print out "Hello" as the message for the assertion. This had an underlying reason, in that it was trying to helpfully keep the messages around in case of unexpected exceptions, so that code like this: ```cpp TEST_CASE() { auto [input, expected] = GENERATE(...); CAPTURE(input); auto result = transform(input); // throws REQUIRE(result == expected); } ``` would report the value of `input` when `transform` throws. However, it was surprising in practice and was causing various issues around handling of messages in other cases. Closes #1759 Closes #2019 Closes #2959
Diffstat (limited to 'tests/TestScripts')
0 files changed, 0 insertions, 0 deletions