Read-only mirrors. Development, issues and pull requests are on GitHub.

summaryrefslogtreecommitdiffhomepage
path: root/tests
diff options
context:
space:
mode:
authorMartin Hořeňovský2021-11-07 23:31:44 +0100
committerMartin Hořeňovský2021-11-09 11:50:03 +0100
commit8780425385787242092333d72e30b2217cb2f6b3 (patch)
treedf69ea71c89b4ae1808d3be1e4dbfe314e06f1df /tests
parent7800fe970864199aa6c064aa49baa5fb3463a817 (diff)
downloadcatch3-8780425385787242092333d72e30b2217cb2f6b3.tar.gz
Make reporter lookup case insensitive, registration case preserving
Previously registration was case preserving, but lookup used lowercased reporter name, so a reporter whose name contained upper case character could not be requested by the user.
Diffstat (limited to 'tests')
-rw-r--r--tests/ExtraTests/CMakeLists.txt22
-rw-r--r--tests/ExtraTests/X23-CasingInReporterNames.cpp40
2 files changed, 62 insertions, 0 deletions
diff --git a/tests/ExtraTests/CMakeLists.txt b/tests/ExtraTests/CMakeLists.txt
index f2add6d6..0dd0f0cf 100644
--- a/tests/ExtraTests/CMakeLists.txt
+++ b/tests/ExtraTests/CMakeLists.txt
@@ -197,6 +197,28 @@ add_test(
)
+add_executable(CasingInReporterNames ${TESTS_DIR}/X23-CasingInReporterNames.cpp)
+target_link_libraries(CasingInReporterNames PRIVATE Catch2::Catch2WithMain)
+add_test(
+ NAME Reporters::registration-is-case-preserving
+ COMMAND CasingInReporterNames --list-reporters
+)
+set_tests_properties(
+ Reporters::registration-is-case-preserving
+ PROPERTIES
+ PASS_REGULAR_EXPRESSION "testReporterCASED"
+)
+add_test(
+ NAME Reporters::selection-is-case-insensitive
+ COMMAND CasingInReporterNames -r testReportercased
+)
+set_tests_properties(
+ Reporters::selection-is-case-insensitive
+ PROPERTIES
+ PASS_REGULAR_EXPRESSION "TestReporter constructed"
+)
+
+
add_executable(DuplicatedTestCases-SameNameAndTags ${TESTS_DIR}/X31-DuplicatedTestCases.cpp)
target_link_libraries(DuplicatedTestCases-SameNameAndTags PRIVATE Catch2::Catch2WithMain)
add_test(
diff --git a/tests/ExtraTests/X23-CasingInReporterNames.cpp b/tests/ExtraTests/X23-CasingInReporterNames.cpp
new file mode 100644
index 00000000..48c0b30d
--- /dev/null
+++ b/tests/ExtraTests/X23-CasingInReporterNames.cpp
@@ -0,0 +1,40 @@
+
+// Copyright Catch2 Authors
+// Distributed under the Boost Software License, Version 1.0.
+// (See accompanying file LICENSE_1_0.txt or copy at
+// https://www.boost.org/LICENSE_1_0.txt)
+
+// SPDX-License-Identifier: BSL-1.0
+
+/**\file
+ * Test that reporter registration is case-preserving, selection is
+ * case-insensitive.
+ *
+ * This is done by registering a custom reporter that prints out a marker
+ * string upon construction and then invoking the binary with different
+ * casings of the name.
+ */
+
+#include <catch2/reporters/catch_reporter_streaming_base.hpp>
+#include <catch2/catch_reporter_registrars.hpp>
+
+#include <iostream>
+
+class TestReporter : public Catch::StreamingReporterBase {
+public:
+ TestReporter(Catch::ReporterConfig const& _config):
+ StreamingReporterBase(_config) {
+ std::cout << "TestReporter constructed\n";
+ }
+
+ static std::string getDescription() {
+ return "Reporter for testing casing handling in reporter registration/selection";
+ }
+
+ ~TestReporter() override;
+};
+
+TestReporter::~TestReporter() = default;
+
+CATCH_REGISTER_REPORTER("testReporterCASED", TestReporter)
+