diff options
| author | Martin Hořeňovský | 2021-06-09 20:48:58 +0200 |
|---|---|---|
| committer | Martin Hořeňovský | 2021-08-07 15:16:11 +0200 |
| commit | 0a3f511cfed071c9c4ad512341ae7569383922b7 (patch) | |
| tree | 9bb28fd5a87cd1fffc96832fafeb244c6bef29a7 /tests/SelfTest | |
| parent | 9ef510b7694c7199a78d13a8cba8ddbdeac7cb16 (diff) | |
| download | catch3-0a3f511cfed071c9c4ad512341ae7569383922b7.tar.gz | |
Fix inconsistencies in reporting benchmarking failures
With these changes, all these benchmarks
```cpp
BENCHMARK("Empty benchmark") {};
BENCHMARK("Throwing benchmark") {
throw "just a plain literal, bleh";
};
BENCHMARK("Asserting benchmark") {
REQUIRE(1 == 2);
};
BENCHMARK("FAIL'd benchmark") {
FAIL("This benchmark only fails, nothing else");
};
```
report the respective failure and mark the outer `TEST_CASE` as
failed. Previously, the first two would not fail the `TEST_CASE`,
and the latter two would break xml reporter's formatting, because
`benchmarkFailed`, `benchmarkEnded` etc would not be be called
properly in failure cases.
Diffstat (limited to 'tests/SelfTest')
| -rw-r--r-- | tests/SelfTest/IntrospectiveTests/InternalBenchmark.tests.cpp | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/tests/SelfTest/IntrospectiveTests/InternalBenchmark.tests.cpp b/tests/SelfTest/IntrospectiveTests/InternalBenchmark.tests.cpp index 0a3895a8..b2250415 100644 --- a/tests/SelfTest/IntrospectiveTests/InternalBenchmark.tests.cpp +++ b/tests/SelfTest/IntrospectiveTests/InternalBenchmark.tests.cpp @@ -412,3 +412,24 @@ TEST_CASE("run benchmark", "[benchmark][approvals]") { CHECK((end - start).count() == 2867251000); } + +TEST_CASE("Failing benchmarks", "[!benchmark][.approvals]") { + SECTION("empty", "Benchmark that has been optimized away (because it is empty)") { + BENCHMARK("Empty benchmark") {}; + } + SECTION("throw", "Benchmark that throws an exception") { + BENCHMARK("Throwing benchmark") { + throw "just a plain literal, bleh"; + }; + } + SECTION("assert", "Benchmark that asserts inside") { + BENCHMARK("Asserting benchmark") { + REQUIRE(1 == 2); + }; + } + SECTION("fail", "Benchmark that fails inside") { + BENCHMARK("FAIL'd benchmark") { + FAIL("This benchmark only fails, nothing else"); + }; + } +} |