diff options
| author | Martin Hořeňovský | 2020-03-18 20:59:25 +0100 |
|---|---|---|
| committer | Martin Hořeňovský | 2020-04-29 21:27:57 +0200 |
| commit | 60cfaa38fbd7a9a0fa2366e70367aef3696efc73 (patch) | |
| tree | 6687b0c01a3813858e88b508fcbdb3d9a6b9e656 /tests/SelfTest/UsageTests/Compilation.tests.cpp | |
| parent | 38a0dfca6d9e6d62098b80d4f87ad56cf135b09e (diff) | |
| download | catch3-60cfaa38fbd7a9a0fa2366e70367aef3696efc73.tar.gz | |
Make warnings in assertions fire for GCC/Clang again
The old code caused warnings to fire under MSVC, and Clang <3.8.
I could not find a GCC version where it worked, but I assume that it
did at some point.
This new code causes all of MSVC, GCC, Clang, in current versions,
to emit signed/unsigned comparison warning in test like this:
```cpp
TEST_CASE() {
int32_t i = -1;
uint32_t j = 1;
REQUIRE(i != j);
}
```
Where previously only MSVC would emit the warning.
Fixes #1880
Diffstat (limited to 'tests/SelfTest/UsageTests/Compilation.tests.cpp')
| -rw-r--r-- | tests/SelfTest/UsageTests/Compilation.tests.cpp | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/tests/SelfTest/UsageTests/Compilation.tests.cpp b/tests/SelfTest/UsageTests/Compilation.tests.cpp index 1c43c1c3..839a1662 100644 --- a/tests/SelfTest/UsageTests/Compilation.tests.cpp +++ b/tests/SelfTest/UsageTests/Compilation.tests.cpp @@ -202,10 +202,19 @@ namespace { namespace CompilationTests { inline static void synchronizing_callback( void * ) { } } +#if defined (_MSC_VER) +#pragma warning(push) +// The function pointer comparison below triggers warning because of +// calling conventions +#pragma warning(disable:4244) +#endif TEST_CASE("#925: comparing function pointer to function address failed to compile", "[!nonportable]" ) { TestClass test; REQUIRE(utility::synchronizing_callback != test.testMethod_uponComplete_arg); } +#if defined (_MSC_VER) +#pragma warning(pop) +#endif TEST_CASE( "#1027: Bitfields can be captured" ) { struct Y { |