Read-only mirrors. Development, issues and pull requests are on GitHub.

summaryrefslogtreecommitdiffhomepage
path: root/src
diff options
context:
space:
mode:
authorMartin Hořeňovský2021-05-12 23:31:08 +0200
committerMartin Hořeňovský2021-05-12 23:55:46 +0200
commitb36f8daaada443fc208d6ceb1c9bf071af86ed94 (patch)
treeaa28ff17ee5820278656423b46cb4859ee2783bb /src
parentd86cb5f95d890d4a62990e0658b5e4ffbf967927 (diff)
downloadcatch3-b36f8daaada443fc208d6ceb1c9bf071af86ed94.tar.gz
Clarify bunch of default, out of line destructors
Diffstat (limited to 'src')
-rw-r--r--src/catch2/interfaces/catch_interfaces_enum_values_registry.hpp2
-rw-r--r--src/catch2/interfaces/catch_interfaces_exception.hpp4
-rw-r--r--src/catch2/interfaces/catch_interfaces_registry_hub.hpp4
-rw-r--r--src/catch2/interfaces/catch_interfaces_reporter_registry.hpp2
-rw-r--r--src/catch2/interfaces/catch_interfaces_tag_alias_registry.hpp2
-rw-r--r--src/catch2/interfaces/catch_interfaces_testcase.hpp4
-rw-r--r--src/catch2/internal/catch_context.hpp4
-rw-r--r--src/catch2/internal/catch_enum_values_registry.cpp2
-rw-r--r--src/catch2/internal/catch_singletons.cpp2
-rw-r--r--src/catch2/internal/catch_singletons.hpp2
-rw-r--r--src/catch2/internal/catch_stream.hpp2
-rw-r--r--src/catch2/internal/catch_tag_alias_registry.cpp2
-rw-r--r--src/catch2/internal/catch_test_case_tracker.hpp2
13 files changed, 17 insertions, 17 deletions
diff --git a/src/catch2/interfaces/catch_interfaces_enum_values_registry.hpp b/src/catch2/interfaces/catch_interfaces_enum_values_registry.hpp
index 2c18059a..e00f2c9d 100644
--- a/src/catch2/interfaces/catch_interfaces_enum_values_registry.hpp
+++ b/src/catch2/interfaces/catch_interfaces_enum_values_registry.hpp
@@ -26,7 +26,7 @@ namespace Catch {
} // namespace Detail
struct IMutableEnumValuesRegistry {
- virtual ~IMutableEnumValuesRegistry();
+ virtual ~IMutableEnumValuesRegistry(); // = default;
virtual Detail::EnumInfo const& registerEnum( StringRef enumName, StringRef allEnums, std::vector<int> const& values ) = 0;
diff --git a/src/catch2/interfaces/catch_interfaces_exception.hpp b/src/catch2/interfaces/catch_interfaces_exception.hpp
index 5d660873..c1834074 100644
--- a/src/catch2/interfaces/catch_interfaces_exception.hpp
+++ b/src/catch2/interfaces/catch_interfaces_exception.hpp
@@ -21,12 +21,12 @@ namespace Catch {
using ExceptionTranslators = std::vector<Detail::unique_ptr<IExceptionTranslator const>>;
struct IExceptionTranslator {
- virtual ~IExceptionTranslator();
+ virtual ~IExceptionTranslator(); // = default
virtual std::string translate( ExceptionTranslators::const_iterator it, ExceptionTranslators::const_iterator itEnd ) const = 0;
};
struct IExceptionTranslatorRegistry {
- virtual ~IExceptionTranslatorRegistry();
+ virtual ~IExceptionTranslatorRegistry(); // = default
virtual std::string translateActiveException() const = 0;
};
diff --git a/src/catch2/interfaces/catch_interfaces_registry_hub.hpp b/src/catch2/interfaces/catch_interfaces_registry_hub.hpp
index bea1f7d4..71f2faa2 100644
--- a/src/catch2/interfaces/catch_interfaces_registry_hub.hpp
+++ b/src/catch2/interfaces/catch_interfaces_registry_hub.hpp
@@ -31,7 +31,7 @@ namespace Catch {
using IReporterFactoryPtr = Detail::unique_ptr<IReporterFactory>;
struct IRegistryHub {
- virtual ~IRegistryHub();
+ virtual ~IRegistryHub(); // = default
virtual IReporterRegistry const& getReporterRegistry() const = 0;
virtual ITestCaseRegistry const& getTestCaseRegistry() const = 0;
@@ -43,7 +43,7 @@ namespace Catch {
};
struct IMutableRegistryHub {
- virtual ~IMutableRegistryHub();
+ virtual ~IMutableRegistryHub(); // = default
virtual void registerReporter( std::string const& name, IReporterFactoryPtr factory ) = 0;
virtual void registerListener( IReporterFactoryPtr factory ) = 0;
virtual void registerTest(Detail::unique_ptr<TestCaseInfo>&& testInfo, Detail::unique_ptr<ITestInvoker>&& invoker) = 0;
diff --git a/src/catch2/interfaces/catch_interfaces_reporter_registry.hpp b/src/catch2/interfaces/catch_interfaces_reporter_registry.hpp
index 05195f37..54871cce 100644
--- a/src/catch2/interfaces/catch_interfaces_reporter_registry.hpp
+++ b/src/catch2/interfaces/catch_interfaces_reporter_registry.hpp
@@ -27,7 +27,7 @@ namespace Catch {
using FactoryMap = std::map<std::string, IReporterFactoryPtr>;
using Listeners = std::vector<IReporterFactoryPtr>;
- virtual ~IReporterRegistry();
+ virtual ~IReporterRegistry(); // = default
virtual IStreamingReporterPtr create( std::string const& name, IConfig const* config ) const = 0;
virtual FactoryMap const& getFactories() const = 0;
virtual Listeners const& getListeners() const = 0;
diff --git a/src/catch2/interfaces/catch_interfaces_tag_alias_registry.hpp b/src/catch2/interfaces/catch_interfaces_tag_alias_registry.hpp
index 152fdc23..6b0973b4 100644
--- a/src/catch2/interfaces/catch_interfaces_tag_alias_registry.hpp
+++ b/src/catch2/interfaces/catch_interfaces_tag_alias_registry.hpp
@@ -15,7 +15,7 @@ namespace Catch {
struct TagAlias;
struct ITagAliasRegistry {
- virtual ~ITagAliasRegistry();
+ virtual ~ITagAliasRegistry(); // = default
// Nullptr if not present
virtual TagAlias const* find( std::string const& alias ) const = 0;
virtual std::string expandAliases( std::string const& unexpandedTestSpec ) const = 0;
diff --git a/src/catch2/interfaces/catch_interfaces_testcase.hpp b/src/catch2/interfaces/catch_interfaces_testcase.hpp
index aad5ea20..2d0b6c28 100644
--- a/src/catch2/interfaces/catch_interfaces_testcase.hpp
+++ b/src/catch2/interfaces/catch_interfaces_testcase.hpp
@@ -17,14 +17,14 @@ namespace Catch {
struct ITestInvoker {
virtual void invoke () const = 0;
- virtual ~ITestInvoker();
+ virtual ~ITestInvoker(); // = default
};
class TestCaseHandle;
struct IConfig;
struct ITestCaseRegistry {
- virtual ~ITestCaseRegistry();
+ virtual ~ITestCaseRegistry(); // = default
// TODO: this exists only for adding filenames to test cases -- let's expose this in a saner way later
virtual std::vector<TestCaseInfo* > const& getAllInfos() const = 0;
virtual std::vector<TestCaseHandle> const& getAllTests() const = 0;
diff --git a/src/catch2/internal/catch_context.hpp b/src/catch2/internal/catch_context.hpp
index 6f660f3a..ca697431 100644
--- a/src/catch2/internal/catch_context.hpp
+++ b/src/catch2/internal/catch_context.hpp
@@ -16,7 +16,7 @@ namespace Catch {
struct IContext
{
- virtual ~IContext();
+ virtual ~IContext(); // = default
virtual IResultCapture* getResultCapture() = 0;
virtual IRunner* getRunner() = 0;
@@ -25,7 +25,7 @@ namespace Catch {
struct IMutableContext : IContext
{
- virtual ~IMutableContext();
+ virtual ~IMutableContext(); // = default
virtual void setResultCapture( IResultCapture* resultCapture ) = 0;
virtual void setRunner( IRunner* runner ) = 0;
virtual void setConfig( IConfig const* config ) = 0;
diff --git a/src/catch2/internal/catch_enum_values_registry.cpp b/src/catch2/internal/catch_enum_values_registry.cpp
index b4f425d4..ef4baf9a 100644
--- a/src/catch2/internal/catch_enum_values_registry.cpp
+++ b/src/catch2/internal/catch_enum_values_registry.cpp
@@ -13,7 +13,7 @@
namespace Catch {
- IMutableEnumValuesRegistry::~IMutableEnumValuesRegistry() {}
+ IMutableEnumValuesRegistry::~IMutableEnumValuesRegistry() = default;
namespace Detail {
diff --git a/src/catch2/internal/catch_singletons.cpp b/src/catch2/internal/catch_singletons.cpp
index 36e0e7bd..116fce46 100644
--- a/src/catch2/internal/catch_singletons.cpp
+++ b/src/catch2/internal/catch_singletons.cpp
@@ -20,7 +20,7 @@ namespace Catch {
}
}
- ISingleton::~ISingleton() {}
+ ISingleton::~ISingleton() = default;
void addSingleton(ISingleton* singleton ) {
getSingletons()->push_back( singleton );
diff --git a/src/catch2/internal/catch_singletons.hpp b/src/catch2/internal/catch_singletons.hpp
index 0a7f7ccc..d06d2244 100644
--- a/src/catch2/internal/catch_singletons.hpp
+++ b/src/catch2/internal/catch_singletons.hpp
@@ -11,7 +11,7 @@
namespace Catch {
struct ISingleton {
- virtual ~ISingleton();
+ virtual ~ISingleton(); // = default
};
diff --git a/src/catch2/internal/catch_stream.hpp b/src/catch2/internal/catch_stream.hpp
index 4ff012d2..b764f825 100644
--- a/src/catch2/internal/catch_stream.hpp
+++ b/src/catch2/internal/catch_stream.hpp
@@ -22,7 +22,7 @@ namespace Catch {
std::ostream& clog();
struct IStream {
- virtual ~IStream();
+ virtual ~IStream(); // = default
virtual std::ostream& stream() const = 0;
};
diff --git a/src/catch2/internal/catch_tag_alias_registry.cpp b/src/catch2/internal/catch_tag_alias_registry.cpp
index 5df3c02b..8c3e339f 100644
--- a/src/catch2/internal/catch_tag_alias_registry.cpp
+++ b/src/catch2/internal/catch_tag_alias_registry.cpp
@@ -46,7 +46,7 @@ namespace Catch {
<< "\tRedefined at: " << lineInfo );
}
- ITagAliasRegistry::~ITagAliasRegistry() {}
+ ITagAliasRegistry::~ITagAliasRegistry() = default;
ITagAliasRegistry const& ITagAliasRegistry::get() {
return getRegistryHub().getTagAliasRegistry();
diff --git a/src/catch2/internal/catch_test_case_tracker.hpp b/src/catch2/internal/catch_test_case_tracker.hpp
index c3ed1ae0..db2afa79 100644
--- a/src/catch2/internal/catch_test_case_tracker.hpp
+++ b/src/catch2/internal/catch_test_case_tracker.hpp
@@ -51,7 +51,7 @@ namespace TestCaseTracking {
return m_nameAndLocation;
}
- virtual ~ITracker();
+ virtual ~ITracker(); // = default
// dynamic queries