Read-only mirrors. Development, issues and pull requests are on GitHub.

summaryrefslogtreecommitdiffhomepage
path: root/src
diff options
context:
space:
mode:
authorMartin Hořeňovský2020-02-02 14:43:26 +0100
committerMartin Hořeňovský2020-02-02 14:43:26 +0100
commit3b297cf9b5aae20d152a844903a3260a91e85d65 (patch)
tree216a9003cbe4d15574d53ab4c982811130034ee3 /src
parent66fe591477caa2f6b592e4318f5fd6020664cd29 (diff)
downloadcatch3-3b297cf9b5aae20d152a844903a3260a91e85d65.tar.gz
Outline Config destructor to avoid including superfluous header
Diffstat (limited to 'src')
-rw-r--r--src/catch2/catch_config.cpp4
-rw-r--r--src/catch2/catch_config.hpp5
2 files changed, 5 insertions, 4 deletions
diff --git a/src/catch2/catch_config.cpp b/src/catch2/catch_config.cpp
index 6d579af4..ea7ec3de 100644
--- a/src/catch2/catch_config.cpp
+++ b/src/catch2/catch_config.cpp
@@ -7,6 +7,7 @@
#include <catch2/catch_config.hpp>
#include <catch2/catch_enforce.h>
+#include <catch2/catch_stream.h>
#include <catch2/catch_stringref.h>
namespace Catch {
@@ -36,6 +37,9 @@ namespace Catch {
m_testSpec = parser.testSpec();
}
+ Config::~Config() = default;
+
+
std::string const& Config::getFilename() const {
return m_data.outputFilename ;
}
diff --git a/src/catch2/catch_config.hpp b/src/catch2/catch_config.hpp
index 85a7c84c..55fa5ed8 100644
--- a/src/catch2/catch_config.hpp
+++ b/src/catch2/catch_config.hpp
@@ -11,9 +11,6 @@
#include <catch2/catch_test_spec_parser.h>
#include <catch2/catch_interfaces_config.h>
-// Libstdc++ doesn't like incomplete classes for unique_ptr
-#include <catch2/catch_stream.h>
-
#include <memory>
#include <vector>
#include <string>
@@ -73,7 +70,7 @@ namespace Catch {
Config() = default;
Config( ConfigData const& data );
- virtual ~Config() = default;
+ ~Config() override; // = default in the cpp file
std::string const& getFilename() const;