diff options
| author | Martin Hořeňovský | 2020-02-25 10:40:41 +0100 |
|---|---|---|
| committer | Martin Hořeňovský | 2020-02-26 16:07:41 +0100 |
| commit | 33b47f7309653329fdd160867acd1830d9959ab2 (patch) | |
| tree | d93f29118133ce794515751f48d091e4f6f38285 /src | |
| parent | 8d1e7ca8965e13ed6e12d7e875516f6e240f2bce (diff) | |
| download | catch3-33b47f7309653329fdd160867acd1830d9959ab2.tar.gz | |
Fix warnings from stringifying functions
The only way to stream those is to use the `bool` overload of `op<<`.
However, to convert a function to bool, GCC creates AST equivalent
of `A? true : false`. Then, because `A` is a function, it warns that
it will never be `false`. :facepalm:
As a bonus, newer GCC versions issue _two_ different warnings about
this, but older GCC versions do not know both of them, so we also
have to suppress warning about unknown warning suppression.
Diffstat (limited to 'src')
| -rw-r--r-- | src/catch2/catch_stream.h | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/src/catch2/catch_stream.h b/src/catch2/catch_stream.h index 999849c9..261a80e1 100644 --- a/src/catch2/catch_stream.h +++ b/src/catch2/catch_stream.h @@ -39,11 +39,27 @@ namespace Catch { auto str() const -> std::string; +#if defined(__GNUC__) && !defined(__clang__) +#pragma GCC diagnostic push +// Old versions of GCC do not understand -Wnonnull-compare +#pragma GCC diagnostic ignored "-Wpragmas" +// Streaming a function pointer triggers Waddress and Wnonnull-compare +// on GCC, because it implicitly converts it to bool and then decides +// that the check it uses (a? true : false) is tautological and cannot +// be null... +#pragma GCC diagnostic ignored "-Waddress" +#pragma GCC diagnostic ignored "-Wnonnull-compare" +#endif + template<typename T> auto operator << ( T const& value ) -> ReusableStringStream& { *m_oss << value; return *this; } + +#if defined(__GNUC__) && !defined(__clang__) +#pragma GCC diagnostic pop +#endif auto get() -> std::ostream& { return *m_oss; } }; } |