Read-only mirrors. Development, issues and pull requests are on GitHub.

summaryrefslogtreecommitdiffhomepage
path: root/src/catch2
diff options
context:
space:
mode:
authorMartin Hořeňovský2022-01-07 10:34:15 +0100
committerMartin Hořeňovský2022-01-07 10:34:25 +0100
commit875299cff05560f186eb34e26f7576da61cba65e (patch)
tree42d24070345a66d38f3be65d23de64240bdb43f4 /src/catch2
parent39d3de17f3ec37a975be9bb21dbaf0117b137c5f (diff)
downloadcatch3-875299cff05560f186eb34e26f7576da61cba65e.tar.gz
Remove unused member from Totals
At one point it was inserted there as the simplest way to smuggle around an extra return value for specific errors in executing tests. Since then, the error has been changed to be handled differently, and the member became unused.
Diffstat (limited to 'src/catch2')
-rw-r--r--src/catch2/catch_session.cpp2
-rw-r--r--src/catch2/catch_totals.hpp1
2 files changed, 1 insertions, 2 deletions
diff --git a/src/catch2/catch_session.cpp b/src/catch2/catch_session.cpp
index 5671e831..54b119b0 100644
--- a/src/catch2/catch_session.cpp
+++ b/src/catch2/catch_session.cpp
@@ -330,7 +330,7 @@ namespace Catch {
// Note that on unices only the lower 8 bits are usually used, clamping
// the return value to 255 prevents false negative when some multiple
// of 256 tests has failed
- return (std::min) (MaxExitCode, (std::max) (totals.error, static_cast<int>(totals.assertions.failed)));
+ return (std::min) (MaxExitCode, static_cast<int>(totals.assertions.failed));
}
#if !defined(CATCH_CONFIG_DISABLE_EXCEPTIONS)
catch( std::exception& ex ) {
diff --git a/src/catch2/catch_totals.hpp b/src/catch2/catch_totals.hpp
index a062319c..7ab6a1b6 100644
--- a/src/catch2/catch_totals.hpp
+++ b/src/catch2/catch_totals.hpp
@@ -33,7 +33,6 @@ namespace Catch {
Totals delta( Totals const& prevTotals ) const;
- int error = 0;
Counts assertions;
Counts testCases;
};