Read-only mirrors. Development, issues and pull requests are on GitHub.

summaryrefslogtreecommitdiffhomepage
path: root/src/catch2/internal
diff options
context:
space:
mode:
authorMorwenn2020-10-29 15:04:26 +0100
committerMartin Hořeňovský2020-11-02 16:01:17 +0100
commitdd5652933ae181226eac0177e1b6ab0d988bdec6 (patch)
tree9345464914b1c4604f7cad9f13b6f532c15d7b3b /src/catch2/internal
parent3a15433d527269dcb9fc6452f279626173b94f1d (diff)
downloadcatch3-dd5652933ae181226eac0177e1b6ab0d988bdec6.tar.gz
Silence -Wuseless-cast warning with GCC10
With GCC 10, the `static_cast<bool>` triggers the -Wuseless-cast warning. This commit changes the cast into `static_cast<const bool&>`: it achieves the same thing but doesn't trigger the warning thanks to the "gratuitous" type conversion to `const bool&`. As per references rules, `const bool&` should bind to anything, be it `const` or not, an rvalue or an lvalue, so I doubt that this change is breaking anything.
Diffstat (limited to 'src/catch2/internal')
-rw-r--r--src/catch2/internal/catch_test_macro_impl.hpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/catch2/internal/catch_test_macro_impl.hpp b/src/catch2/internal/catch_test_macro_impl.hpp
index 8cf794af..9ceb03ab 100644
--- a/src/catch2/internal/catch_test_macro_impl.hpp
+++ b/src/catch2/internal/catch_test_macro_impl.hpp
@@ -56,7 +56,7 @@
CATCH_INTERNAL_STOP_WARNINGS_SUPPRESSION \
} INTERNAL_CATCH_CATCH( catchAssertionHandler ) \
INTERNAL_CATCH_REACT( catchAssertionHandler ) \
- } while( (void)0, (false) && static_cast<bool>( !!(__VA_ARGS__) ) )
+ } while( (void)0, (false) && static_cast<const bool&>( !!(__VA_ARGS__) ) )
///////////////////////////////////////////////////////////////////////////////
#define INTERNAL_CATCH_IF( macroName, resultDisposition, ... ) \