Read-only mirrors. Development, issues and pull requests are on GitHub.

summaryrefslogtreecommitdiffhomepage
path: root/src/catch2/internal/catch_commandline.cpp
diff options
context:
space:
mode:
authorMartin Hořeňovský2021-11-07 23:31:44 +0100
committerMartin Hořeňovský2021-11-09 11:50:03 +0100
commit8780425385787242092333d72e30b2217cb2f6b3 (patch)
treedf69ea71c89b4ae1808d3be1e4dbfe314e06f1df /src/catch2/internal/catch_commandline.cpp
parent7800fe970864199aa6c064aa49baa5fb3463a817 (diff)
downloadcatch3-8780425385787242092333d72e30b2217cb2f6b3.tar.gz
Make reporter lookup case insensitive, registration case preserving
Previously registration was case preserving, but lookup used lowercased reporter name, so a reporter whose name contained upper case character could not be requested by the user.
Diffstat (limited to 'src/catch2/internal/catch_commandline.cpp')
-rw-r--r--src/catch2/internal/catch_commandline.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/catch2/internal/catch_commandline.cpp b/src/catch2/internal/catch_commandline.cpp
index 6cf71b77..02056da5 100644
--- a/src/catch2/internal/catch_commandline.cpp
+++ b/src/catch2/internal/catch_commandline.cpp
@@ -140,11 +140,10 @@ namespace Catch {
auto const setReporter = [&]( std::string const& reporter ) {
IReporterRegistry::FactoryMap const& factories = getRegistryHub().getReporterRegistry().getFactories();
- auto lcReporter = toLower( reporter );
- auto result = factories.find( lcReporter );
+ auto result = factories.find( reporter );
if( factories.end() != result )
- config.reporterName = lcReporter;
+ config.reporterName = reporter;
else
return ParserResult::runtimeError( "Unrecognized reporter, '" + reporter + "'. Check available with --list-reporters" );
return ParserResult::ok( ParseResultType::Matched );