diff options
| author | Martin Hořeňovský | 2021-05-14 23:45:59 +0200 |
|---|---|---|
| committer | Martin Hořeňovský | 2021-05-14 23:45:59 +0200 |
| commit | 61e16416a99fe4ba48c1adfc46082276433be6c0 (patch) | |
| tree | 57e892cc11a0d80b0fa9fd90237fdc0d0a186d34 /src/catch2/internal/catch_assertion_handler.hpp | |
| parent | 074017f5ad759328826a93dbea8ea41cc4d6808d (diff) | |
| download | catch3-61e16416a99fe4ba48c1adfc46082276433be6c0.tar.gz | |
Pass other StringRef arguments by value instead of by-ref
Apart from being clearer, it also improves the overall codesize
of the implementation library, and should improve the performance
as well, by removing one level of indirection.
Diffstat (limited to 'src/catch2/internal/catch_assertion_handler.hpp')
| -rw-r--r-- | src/catch2/internal/catch_assertion_handler.hpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/catch2/internal/catch_assertion_handler.hpp b/src/catch2/internal/catch_assertion_handler.hpp index 8e266ade..b7c7613e 100644 --- a/src/catch2/internal/catch_assertion_handler.hpp +++ b/src/catch2/internal/catch_assertion_handler.hpp @@ -32,7 +32,7 @@ namespace Catch { public: AssertionHandler - ( StringRef const& macroName, + ( StringRef macroName, SourceLineInfo const& lineInfo, StringRef capturedExpression, ResultDisposition::Flags resultDisposition ); @@ -49,7 +49,7 @@ namespace Catch { } void handleExpr( ITransientExpression const& expr ); - void handleMessage(ResultWas::OfType resultType, StringRef const& message); + void handleMessage(ResultWas::OfType resultType, StringRef message); void handleExceptionThrownAsExpected(); void handleUnexpectedExceptionNotThrown(); @@ -64,7 +64,7 @@ namespace Catch { auto allowThrows() const -> bool; }; - void handleExceptionMatchExpr( AssertionHandler& handler, std::string const& str, StringRef const& matcherString ); + void handleExceptionMatchExpr( AssertionHandler& handler, std::string const& str, StringRef matcherString ); } // namespace Catch |