diff options
| author | Martin Hořeňovský | 2021-05-12 23:31:08 +0200 |
|---|---|---|
| committer | Martin Hořeňovský | 2021-05-12 23:55:46 +0200 |
| commit | b36f8daaada443fc208d6ceb1c9bf071af86ed94 (patch) | |
| tree | aa28ff17ee5820278656423b46cb4859ee2783bb /src/catch2/interfaces | |
| parent | d86cb5f95d890d4a62990e0658b5e4ffbf967927 (diff) | |
| download | catch3-b36f8daaada443fc208d6ceb1c9bf071af86ed94.tar.gz | |
Clarify bunch of default, out of line destructors
Diffstat (limited to 'src/catch2/interfaces')
6 files changed, 9 insertions, 9 deletions
diff --git a/src/catch2/interfaces/catch_interfaces_enum_values_registry.hpp b/src/catch2/interfaces/catch_interfaces_enum_values_registry.hpp index 2c18059a..e00f2c9d 100644 --- a/src/catch2/interfaces/catch_interfaces_enum_values_registry.hpp +++ b/src/catch2/interfaces/catch_interfaces_enum_values_registry.hpp @@ -26,7 +26,7 @@ namespace Catch { } // namespace Detail struct IMutableEnumValuesRegistry { - virtual ~IMutableEnumValuesRegistry(); + virtual ~IMutableEnumValuesRegistry(); // = default; virtual Detail::EnumInfo const& registerEnum( StringRef enumName, StringRef allEnums, std::vector<int> const& values ) = 0; diff --git a/src/catch2/interfaces/catch_interfaces_exception.hpp b/src/catch2/interfaces/catch_interfaces_exception.hpp index 5d660873..c1834074 100644 --- a/src/catch2/interfaces/catch_interfaces_exception.hpp +++ b/src/catch2/interfaces/catch_interfaces_exception.hpp @@ -21,12 +21,12 @@ namespace Catch { using ExceptionTranslators = std::vector<Detail::unique_ptr<IExceptionTranslator const>>; struct IExceptionTranslator { - virtual ~IExceptionTranslator(); + virtual ~IExceptionTranslator(); // = default virtual std::string translate( ExceptionTranslators::const_iterator it, ExceptionTranslators::const_iterator itEnd ) const = 0; }; struct IExceptionTranslatorRegistry { - virtual ~IExceptionTranslatorRegistry(); + virtual ~IExceptionTranslatorRegistry(); // = default virtual std::string translateActiveException() const = 0; }; diff --git a/src/catch2/interfaces/catch_interfaces_registry_hub.hpp b/src/catch2/interfaces/catch_interfaces_registry_hub.hpp index bea1f7d4..71f2faa2 100644 --- a/src/catch2/interfaces/catch_interfaces_registry_hub.hpp +++ b/src/catch2/interfaces/catch_interfaces_registry_hub.hpp @@ -31,7 +31,7 @@ namespace Catch { using IReporterFactoryPtr = Detail::unique_ptr<IReporterFactory>; struct IRegistryHub { - virtual ~IRegistryHub(); + virtual ~IRegistryHub(); // = default virtual IReporterRegistry const& getReporterRegistry() const = 0; virtual ITestCaseRegistry const& getTestCaseRegistry() const = 0; @@ -43,7 +43,7 @@ namespace Catch { }; struct IMutableRegistryHub { - virtual ~IMutableRegistryHub(); + virtual ~IMutableRegistryHub(); // = default virtual void registerReporter( std::string const& name, IReporterFactoryPtr factory ) = 0; virtual void registerListener( IReporterFactoryPtr factory ) = 0; virtual void registerTest(Detail::unique_ptr<TestCaseInfo>&& testInfo, Detail::unique_ptr<ITestInvoker>&& invoker) = 0; diff --git a/src/catch2/interfaces/catch_interfaces_reporter_registry.hpp b/src/catch2/interfaces/catch_interfaces_reporter_registry.hpp index 05195f37..54871cce 100644 --- a/src/catch2/interfaces/catch_interfaces_reporter_registry.hpp +++ b/src/catch2/interfaces/catch_interfaces_reporter_registry.hpp @@ -27,7 +27,7 @@ namespace Catch { using FactoryMap = std::map<std::string, IReporterFactoryPtr>; using Listeners = std::vector<IReporterFactoryPtr>; - virtual ~IReporterRegistry(); + virtual ~IReporterRegistry(); // = default virtual IStreamingReporterPtr create( std::string const& name, IConfig const* config ) const = 0; virtual FactoryMap const& getFactories() const = 0; virtual Listeners const& getListeners() const = 0; diff --git a/src/catch2/interfaces/catch_interfaces_tag_alias_registry.hpp b/src/catch2/interfaces/catch_interfaces_tag_alias_registry.hpp index 152fdc23..6b0973b4 100644 --- a/src/catch2/interfaces/catch_interfaces_tag_alias_registry.hpp +++ b/src/catch2/interfaces/catch_interfaces_tag_alias_registry.hpp @@ -15,7 +15,7 @@ namespace Catch { struct TagAlias; struct ITagAliasRegistry { - virtual ~ITagAliasRegistry(); + virtual ~ITagAliasRegistry(); // = default // Nullptr if not present virtual TagAlias const* find( std::string const& alias ) const = 0; virtual std::string expandAliases( std::string const& unexpandedTestSpec ) const = 0; diff --git a/src/catch2/interfaces/catch_interfaces_testcase.hpp b/src/catch2/interfaces/catch_interfaces_testcase.hpp index aad5ea20..2d0b6c28 100644 --- a/src/catch2/interfaces/catch_interfaces_testcase.hpp +++ b/src/catch2/interfaces/catch_interfaces_testcase.hpp @@ -17,14 +17,14 @@ namespace Catch { struct ITestInvoker { virtual void invoke () const = 0; - virtual ~ITestInvoker(); + virtual ~ITestInvoker(); // = default }; class TestCaseHandle; struct IConfig; struct ITestCaseRegistry { - virtual ~ITestCaseRegistry(); + virtual ~ITestCaseRegistry(); // = default // TODO: this exists only for adding filenames to test cases -- let's expose this in a saner way later virtual std::vector<TestCaseInfo* > const& getAllInfos() const = 0; virtual std::vector<TestCaseHandle> const& getAllTests() const = 0; |