diff options
| author | Martin Hořeňovský | 2020-08-19 17:44:22 +0200 |
|---|---|---|
| committer | Martin Hořeňovský | 2020-08-20 20:42:21 +0200 |
| commit | 1a97af45f168b24769301906cad9dcfe235d78e5 (patch) | |
| tree | 9ba8714754f38df9e7d446b959d753a385215bc3 /src/catch2/catch_message.cpp | |
| parent | 2e480b6e560ad8412337b49b6327c7ac303bfb01 (diff) | |
| download | catch3-1a97af45f168b24769301906cad9dcfe235d78e5.tar.gz | |
Cleanup some stuff found by MSVC's /analyze
* Added some missing `noexcept`s on custom destructors.
* Fixed `std::move` being called on a const-reference.
* Initialized `ScopedMessage::m_moved` in class definition, instead
of doing so in constructors explicitly.
* Turned some `enum`s into `enum class`es.
* Initialized `StreamingReporterBase::currentTestCaseInfo` in class
definition.
* Some cleanups in SelfTest code.
Diffstat (limited to 'src/catch2/catch_message.cpp')
| -rw-r--r-- | src/catch2/catch_message.cpp | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/catch2/catch_message.cpp b/src/catch2/catch_message.cpp index 6c4a0989..2689592c 100644 --- a/src/catch2/catch_message.cpp +++ b/src/catch2/catch_message.cpp @@ -26,16 +26,14 @@ namespace Catch { //////////////////////////////////////////////////////////////////////////// - ScopedMessage::ScopedMessage( MessageBuilder const& builder ) - : m_info( builder.m_info ), m_moved() - { + ScopedMessage::ScopedMessage( MessageBuilder const& builder ): + m_info( builder.m_info ) { m_info.message = builder.m_stream.str(); getResultCapture().pushScopedMessage( m_info ); } - ScopedMessage::ScopedMessage( ScopedMessage&& old ) - : m_info( old.m_info ), m_moved() - { + ScopedMessage::ScopedMessage( ScopedMessage&& old ) noexcept: + m_info( std::move( old.m_info ) ) { old.m_moved = true; } |