diff options
| author | Leitwolf11 | 2026-11-01 14:48:55 +0300 |
|---|---|---|
| committer | Leitwolf11 | 2026-11-01 14:48:55 +0300 |
| commit | 569620dad14df7e13bb9fd31d256e9fd873ef6ec (patch) | |
| tree | f933300c29658c3eb89d126d74b6c30fdff9dd04 /src/Progmasoft/Runner/ResultImportJson.cpp | |
| parent | 1db203d56b7c71db3d80b477da1ad49e9ae46468 (diff) | |
| download | catch3-feature/result-import.tar.gz | |
Keep real failures visible when importingfeature/result-import
A review of the import found ways for a failure to disappear or for the
import to reach too far.
- CTRF's retryAttempts ends before the final attempt, which was dropped when
its outcome matched the one before it.
- TAP names tests only within a stream, so a failure in one file and a pass
under the same name in another merged into a flaky pass. The path given to
--import is now the class of a stream's tests.
- A failure followed by a skip with the same identifier read as skipped.
- Directives are whole words: TODOING is not TODO. SKIPPED and SKIPPING stay
directives, as harnesses treat them.
- Verdicts that alternate count as flaky only under an explicit
--import-revision. HEAD says nothing about a dirty checkout or a report from
another one, and two such events could quarantine a real failure.
- --import-name no longer redirects the history of a normal test run.
- Importing does not depend on the tests registered in the binary.
Diffstat (limited to 'src/Progmasoft/Runner/ResultImportJson.cpp')
| -rw-r--r-- | src/Progmasoft/Runner/ResultImportJson.cpp | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/Progmasoft/Runner/ResultImportJson.cpp b/src/Progmasoft/Runner/ResultImportJson.cpp index 2cdc2019..1651f938 100644 --- a/src/Progmasoft/Runner/ResultImportJson.cpp +++ b/src/Progmasoft/Runner/ResultImportJson.cpp @@ -244,14 +244,9 @@ namespace Progmasoft::Catch3::Runner { test.attempts.push_back(CtrfAttempt(retry)); } - // The retries may or may not list the last attempt, which - // is the test itself. - Attempt last = CtrfAttempt(item); - if (test.attempts.empty() - || test.attempts.back().outcome != last.outcome) - { - test.attempts.push_back(std::move(last)); - } + // The retries end before the last attempt, which is the + // test itself. + test.attempts.push_back(CtrfAttempt(item)); results.push_back(std::move(test)); } return results; |