Answer the review of the mocksfeature/mocking

A report no longer throws, so a noexcept mock survives an aborting run.
A call that has nothing to return still leaves the test case, which ends
the process in a noexcept function; the documentation says so.

RunContext clears the result capture when it goes, so a mock of static
lifetime finds none and writes to standard error.

Decision owns its source line, since Verify can free the expectation
while a call is on its way. Moving a result out takes the lock. Vector
matchers refer to their vector, so they are rejected at compile time
like composed ones. A null text expectation accepts only null, and
integers compare by value, so 256 no longer accepts an unsigned char.

1 files changed, 4 insertions, 11 deletions

diff --git a/src/Progmasoft/Mock.cpp b/src/Progmasoft/Mock.cpp
index b1364450..bc7945f5 100644
--- a/src/Progmasoft/Mock.cpp
+++ b/src/Progmasoft/Mock.cpp
@@ -9,7 +9,6 @@
 #include <algorithm>
 #include <cstdio>
 #include <cstdlib>
-#include <exception>
 
 namespace Progmasoft::Catch3::Detail
 {
@@ -101,16 +100,15 @@ namespace Progmasoft::Catch3::Detail
     void
     ReportMockFailure(const Catch::SourceLineInfo &line,
                       const std::string &mock,
-                      std::string message,
-                      MockReport report)
+                      std::string message)
     {
         if (!InTestCase())
         {
             WriteToStandardError(line, mock, message);
             return;
         }
-        // An aborting run throws out of any failure, and a destructor must
-        // not let that through.
+        // An aborting run throws out of any failure. The run still stops, at
+        // its next assertion.
         CATCH_TRY
         {
             Report(line,
@@ -120,12 +118,7 @@ namespace Progmasoft::Catch3::Detail
                    Catch::ResultDisposition::ContinueOnFailure);
         }
         CATCH_CATCH_ALL
-        {
-            if (report == MockReport::kContinue)
-            {
-                std::rethrow_exception(std::current_exception());
-            }
-        }
+        {}
     }
 
     void