diff options
| author | Phil Nash | 2017-07-20 15:57:17 +0100 |
|---|---|---|
| committer | Phil Nash | 2017-07-20 16:23:52 +0100 |
| commit | f0890dcdf89d305862d0ba3518752c4becb65773 (patch) | |
| tree | af08ff3533f50095a1204140f05da71a93ea8e14 /include | |
| parent | 74ab1cd94b90886dd54dbf2cc4333fc4ff805291 (diff) | |
| download | catch3-f0890dcdf89d305862d0ba3518752c4becb65773.tar.gz | |
removed redundant virtuals on override functions (and added a couple of overrides)
Diffstat (limited to 'include')
22 files changed, 182 insertions, 205 deletions
diff --git a/include/internal/catch_config.hpp b/include/internal/catch_config.hpp index 36894bec..531543c2 100644 --- a/include/internal/catch_config.hpp +++ b/include/internal/catch_config.hpp @@ -80,19 +80,19 @@ namespace Catch { bool showHelp() const; // IConfig interface - virtual bool allowThrows() const override; - virtual std::ostream& stream() const override; - virtual std::string name() const override; - virtual bool includeSuccessfulResults() const override; - virtual bool warnAboutMissingAssertions() const override; - virtual ShowDurations::OrNot showDurations() const override; - virtual RunTests::InWhatOrder runOrder() const override; - virtual unsigned int rngSeed() const override; - virtual UseColour::YesOrNo useColour() const override; - virtual bool shouldDebugBreak() const override; - virtual int abortAfter() const override; - virtual bool showInvisibles() const override; - virtual Verbosity verbosity() const override; + bool allowThrows() const override; + std::ostream& stream() const override; + std::string name() const override; + bool includeSuccessfulResults() const override; + bool warnAboutMissingAssertions() const override; + ShowDurations::OrNot showDurations() const override; + RunTests::InWhatOrder runOrder() const override; + unsigned int rngSeed() const override; + UseColour::YesOrNo useColour() const override; + bool shouldDebugBreak() const override; + int abortAfter() const override; + bool showInvisibles() const override; + Verbosity verbosity() const override; private: diff --git a/include/internal/catch_expression_lhs.hpp b/include/internal/catch_expression_lhs.hpp index dc32fff7..67db9d65 100644 --- a/include/internal/catch_expression_lhs.hpp +++ b/include/internal/catch_expression_lhs.hpp @@ -81,7 +81,7 @@ public: .endExpression( *this ); } - virtual void reconstructExpression( std::string& dest ) const override { + void reconstructExpression( std::string& dest ) const override { dest = ::Catch::Detail::stringify( m_lhs ); } @@ -117,11 +117,11 @@ public: .endExpression( *this ); } - virtual bool isBinaryExpression() const override { + bool isBinaryExpression() const override { return true; } - virtual void reconstructExpression( std::string& dest ) const override { + void reconstructExpression( std::string& dest ) const override { std::string lhs = ::Catch::Detail::stringify( m_lhs ); std::string rhs = ::Catch::Detail::stringify( m_rhs ); char delim = lhs.size() + rhs.size() < 40 && @@ -151,11 +151,11 @@ public: MatchExpression( ArgT arg, MatcherT matcher, char const* matcherString ) : m_arg( arg ), m_matcher( matcher ), m_matcherString( matcherString ) {} - virtual bool isBinaryExpression() const override { + bool isBinaryExpression() const override { return true; } - virtual void reconstructExpression( std::string& dest ) const override { + void reconstructExpression( std::string& dest ) const override { std::string matcherAsString = m_matcher.toString(); dest = ::Catch::Detail::stringify( m_arg ); dest += ' '; diff --git a/include/internal/catch_matchers.hpp b/include/internal/catch_matchers.hpp index 2083db73..4f41cb01 100644 --- a/include/internal/catch_matchers.hpp +++ b/include/internal/catch_matchers.hpp @@ -53,14 +53,14 @@ namespace Matchers { template<typename ArgT> struct MatchAllOf : MatcherBase<ArgT> { - virtual bool match( ArgT const& arg ) const override { + bool match( ArgT const& arg ) const override { for( auto matcher : m_matchers ) { if (!matcher->match(arg)) return false; } return true; } - virtual std::string describe() const override { + std::string describe() const override { std::string description; description.reserve( 4 + m_matchers.size()*32 ); description += "( "; @@ -86,14 +86,14 @@ namespace Matchers { template<typename ArgT> struct MatchAnyOf : MatcherBase<ArgT> { - virtual bool match( ArgT const& arg ) const override { + bool match( ArgT const& arg ) const override { for( auto matcher : m_matchers ) { if (matcher->match(arg)) return true; } return false; } - virtual std::string describe() const override { + std::string describe() const override { std::string description; description.reserve( 4 + m_matchers.size()*32 ); description += "( "; @@ -122,11 +122,11 @@ namespace Matchers { MatchNotOf( MatcherBase<ArgT> const& underlyingMatcher ) : m_underlyingMatcher( underlyingMatcher ) {} - virtual bool match( ArgT const& arg ) const override { + bool match( ArgT const& arg ) const override { return !m_underlyingMatcher.match( arg ); } - virtual std::string describe() const override { + std::string describe() const override { return "not " + m_underlyingMatcher.toString(); } MatcherBase<ArgT> const& m_underlyingMatcher; diff --git a/include/internal/catch_matchers_string.h b/include/internal/catch_matchers_string.h index 2192ee8f..eca35789 100644 --- a/include/internal/catch_matchers_string.h +++ b/include/internal/catch_matchers_string.h @@ -29,7 +29,7 @@ namespace Matchers { struct StringMatcherBase : MatcherBase<std::string> { StringMatcherBase( std::string const& operation, CasedString const& comparator ); - virtual std::string describe() const override; + std::string describe() const override; CasedString m_comparator; std::string m_operation; @@ -37,19 +37,19 @@ namespace Matchers { struct EqualsMatcher : StringMatcherBase { EqualsMatcher( CasedString const& comparator ); - virtual bool match( std::string const& source ) const override; + bool match( std::string const& source ) const override; }; struct ContainsMatcher : StringMatcherBase { ContainsMatcher( CasedString const& comparator ); - virtual bool match( std::string const& source ) const override; + bool match( std::string const& source ) const override; }; struct StartsWithMatcher : StringMatcherBase { StartsWithMatcher( CasedString const& comparator ); - virtual bool match( std::string const& source ) const override; + bool match( std::string const& source ) const override; }; struct EndsWithMatcher : StringMatcherBase { EndsWithMatcher( CasedString const& comparator ); - virtual bool match( std::string const& source ) const override; + bool match( std::string const& source ) const override; }; } // namespace StdString diff --git a/include/internal/catch_matchers_vector.h b/include/internal/catch_matchers_vector.h index e80f7e12..1f9e0a61 100644 --- a/include/internal/catch_matchers_vector.h +++ b/include/internal/catch_matchers_vector.h @@ -24,7 +24,7 @@ namespace Matchers { return std::find(v.begin(), v.end(), m_comparator) != v.end(); } - virtual std::string describe() const override { + std::string describe() const override { return "Contains: " + ::Catch::Detail::stringify( m_comparator ); } @@ -45,7 +45,7 @@ namespace Matchers { return false; return true; } - virtual std::string describe() const override { + std::string describe() const override { return "Contains: " + ::Catch::Detail::stringify( m_comparator ); } @@ -69,7 +69,7 @@ namespace Matchers { return false; return true; } - virtual std::string describe() const override { + std::string describe() const override { return "Equals: " + ::Catch::Detail::stringify( m_comparator ); } std::vector<T> const& m_comparator; diff --git a/include/internal/catch_objc.hpp b/include/internal/catch_objc.hpp index 8b11d83e..350dc72c 100644 --- a/include/internal/catch_objc.hpp +++ b/include/internal/catch_objc.hpp @@ -112,7 +112,7 @@ namespace Catch { arcSafeRelease( m_substr ); } - virtual bool match( NSString* arg ) const override { + bool match( NSString* arg ) const override { return false; } @@ -122,12 +122,12 @@ namespace Catch { struct Equals : StringHolder { Equals( NSString* substr ) : StringHolder( substr ){} - virtual bool match( NSString* str ) const override { + bool match( NSString* str ) const override { return (str != nil || m_substr == nil ) && [str isEqualToString:m_substr]; } - virtual std::string describe() const override { + std::string describe() const override { return "equals string: " + Catch::toString( m_substr ); } }; @@ -135,12 +135,12 @@ namespace Catch { struct Contains : StringHolder { Contains( NSString* substr ) : StringHolder( substr ){} - virtual bool match( NSString* str ) const { + bool match( NSString* str ) const { return (str != nil || m_substr == nil ) && [str rangeOfString:m_substr].location != NSNotFound; } - virtual std::string describe() const override { + std::string describe() const override { return "contains string: " + Catch::toString( m_substr ); } }; @@ -148,24 +148,24 @@ namespace Catch { struct StartsWith : StringHolder { StartsWith( NSString* substr ) : StringHolder( substr ){} - virtual bool match( NSString* str ) const { + bool match( NSString* str ) const override { return (str != nil || m_substr == nil ) && [str rangeOfString:m_substr].location == 0; } - virtual std::string describe() const override { + std::string describe() const override { return "starts with: " + Catch::toString( m_substr ); } }; struct EndsWith : StringHolder { EndsWith( NSString* substr ) : StringHolder( substr ){} - virtual bool match( NSString* str ) const { + bool match( NSString* str ) const override { return (str != nil || m_substr == nil ) && [str rangeOfString:m_substr].location == [str length] - [m_substr length]; } - virtual std::string describe() const override { + std::string describe() const override { return "ends with: " + Catch::toString( m_substr ); } }; diff --git a/include/internal/catch_registry_hub.cpp b/include/internal/catch_registry_hub.cpp index 12af6e38..01208e77 100644 --- a/include/internal/catch_registry_hub.cpp +++ b/include/internal/catch_registry_hub.cpp @@ -24,39 +24,39 @@ namespace Catch { public: // IRegistryHub RegistryHub() { } - virtual IReporterRegistry const& getReporterRegistry() const override { + IReporterRegistry const& getReporterRegistry() const override { return m_reporterRegistry; } - virtual ITestCaseRegistry const& getTestCaseRegistry() const override { + ITestCaseRegistry const& getTestCaseRegistry() const override { return m_testCaseRegistry; } - virtual IExceptionTranslatorRegistry& getExceptionTranslatorRegistry() override { + IExceptionTranslatorRegistry& getExceptionTranslatorRegistry() override { return m_exceptionTranslatorRegistry; } - virtual ITagAliasRegistry const& getTagAliasRegistry() const override { + ITagAliasRegistry const& getTagAliasRegistry() const override { return m_tagAliasRegistry; } - virtual StartupExceptionRegistry const& getStartupExceptionRegistry() const override { + StartupExceptionRegistry const& getStartupExceptionRegistry() const override { return m_exceptionRegistry; } public: // IMutableRegistryHub - virtual void registerReporter( std::string const& name, IReporterFactoryPtr const& factory ) override { + void registerReporter( std::string const& name, IReporterFactoryPtr const& factory ) override { m_reporterRegistry.registerReporter( name, factory ); } - virtual void registerListener( IReporterFactoryPtr const& factory ) override { + void registerListener( IReporterFactoryPtr const& factory ) override { m_reporterRegistry.registerListener( factory ); } - virtual void registerTest( TestCase const& testInfo ) override { + void registerTest( TestCase const& testInfo ) override { m_testCaseRegistry.registerTest( testInfo ); } - virtual void registerTranslator( const IExceptionTranslator* translator ) override { + void registerTranslator( const IExceptionTranslator* translator ) override { m_exceptionTranslatorRegistry.registerTranslator( translator ); } - virtual void registerTagAlias( std::string const& alias, std::string const& tag, SourceLineInfo const& lineInfo ) override { + void registerTagAlias( std::string const& alias, std::string const& tag, SourceLineInfo const& lineInfo ) override { m_tagAliasRegistry.add( alias, tag, lineInfo ); } - virtual void registerStartupException( std::exception_ptr const& exception ) noexcept override { + void registerStartupException( std::exception_ptr const& exception ) noexcept override { m_exceptionRegistry.add(exception); } diff --git a/include/internal/catch_reporter_registry.hpp b/include/internal/catch_reporter_registry.hpp index 9556fb31..0c015fb9 100644 --- a/include/internal/catch_reporter_registry.hpp +++ b/include/internal/catch_reporter_registry.hpp @@ -18,9 +18,9 @@ namespace Catch { public: - virtual ~ReporterRegistry() override {} + ~ReporterRegistry() override {} - virtual IStreamingReporterPtr create( std::string const& name, IConfigPtr const& config ) const override { + IStreamingReporterPtr create( std::string const& name, IConfigPtr const& config ) const override { FactoryMap::const_iterator it = m_factories.find( name ); if( it == m_factories.end() ) return nullptr; @@ -34,10 +34,10 @@ namespace Catch { m_listeners.push_back( factory ); } - virtual FactoryMap const& getFactories() const override { + FactoryMap const& getFactories() const override { return m_factories; } - virtual Listeners const& getListeners() const override { + Listeners const& getListeners() const override { return m_listeners; } diff --git a/include/internal/catch_result_builder.h b/include/internal/catch_result_builder.h index d442ce40..4c5c5d80 100644 --- a/include/internal/catch_result_builder.h +++ b/include/internal/catch_result_builder.h @@ -50,7 +50,7 @@ namespace Catch { void endExpression( DecomposedExpression const& expr ); - virtual void reconstructExpression( std::string& dest ) const override; + void reconstructExpression( std::string& dest ) const override; AssertionResult build() const; AssertionResult build( DecomposedExpression const& expr ) const; diff --git a/include/internal/catch_stream.h b/include/internal/catch_stream.h index baa10c44..8f2fb5a6 100644 --- a/include/internal/catch_stream.h +++ b/include/internal/catch_stream.h @@ -31,9 +31,9 @@ namespace Catch { mutable std::ofstream m_ofs; public: FileStream( std::string const& filename ); - virtual ~FileStream() noexcept; + ~FileStream() noexcept override; public: // IStream - virtual std::ostream& stream() const override; + std::ostream& stream() const override; }; @@ -41,10 +41,10 @@ namespace Catch { mutable std::ostream m_os; public: CoutStream(); - virtual ~CoutStream() noexcept; + ~CoutStream() noexcept override; public: // IStream - virtual std::ostream& stream() const override; + std::ostream& stream() const override; }; @@ -53,10 +53,10 @@ namespace Catch { mutable std::ostream m_os; public: DebugOutStream(); - virtual ~DebugOutStream() noexcept; + ~DebugOutStream() noexcept override; public: // IStream - virtual std::ostream& stream() const override; + std::ostream& stream() const override; }; } diff --git a/include/internal/catch_tag_alias_registry.h b/include/internal/catch_tag_alias_registry.h index aea41275..d05c7739 100644 --- a/include/internal/catch_tag_alias_registry.h +++ b/include/internal/catch_tag_alias_registry.h @@ -16,9 +16,9 @@ namespace Catch { class TagAliasRegistry : public ITagAliasRegistry { public: - virtual ~TagAliasRegistry(); - virtual Option<TagAlias> find( std::string const& alias ) const; - virtual std::string expandAliases( std::string const& unexpandedTestSpec ) const; + ~TagAliasRegistry() override; + Option<TagAlias> find( std::string const& alias ) const override; + std::string expandAliases( std::string const& unexpandedTestSpec ) const override; void add( std::string const& alias, std::string const& tag, SourceLineInfo const& lineInfo ); private: diff --git a/include/internal/catch_test_case_registry_impl.hpp b/include/internal/catch_test_case_registry_impl.hpp index 5bb32f5e..068ffe58 100644 --- a/include/internal/catch_test_case_registry_impl.hpp +++ b/include/internal/catch_test_case_registry_impl.hpp @@ -96,10 +96,10 @@ namespace Catch { m_functions.push_back( testCase ); } - virtual std::vector<TestCase> const& getAllTests() const { + std::vector<TestCase> const& getAllTests() const override { return m_functions; } - virtual std::vector<TestCase> const& getAllTestsSorted( IConfig const& config ) const { + std::vector<TestCase> const& getAllTestsSorted( IConfig const& config ) const override { if( m_sortedFunctions.empty() ) enforceNoDuplicateTestCases( m_functions ); diff --git a/include/internal/catch_test_case_tracker.hpp b/include/internal/catch_test_case_tracker.hpp index 964b45f9..39509300 100644 --- a/include/internal/catch_test_case_tracker.hpp +++ b/include/internal/catch_test_case_tracker.hpp @@ -59,7 +59,7 @@ namespace TestCaseTracking { virtual bool isIndexTracker() const = 0; }; - class TrackerContext { + class TrackerContext { enum RunState { NotStarted, @@ -113,30 +113,29 @@ namespace TestCaseTracking { public: TrackerBase( NameAndLocation const& nameAndLocation, TrackerContext& ctx, ITracker* parent ); - virtual ~TrackerBase() = default; - virtual NameAndLocation const& nameAndLocation() const override; - virtual bool isComplete() const override; - virtual bool isSuccessfullyCompleted() const override; - virtual bool isOpen() const override; - virtual bool hasChildren() const override; + NameAndLocation const& nameAndLocation() const override; + bool isComplete() const override; + bool isSuccessfullyCompleted() const override; + bool isOpen() const override; + bool hasChildren() const override; - virtual void addChild( ITrackerPtr const& child ) override; + void addChild( ITrackerPtr const& child ) override; - virtual ITrackerPtr findChild( NameAndLocation const& nameAndLocation ) override; - virtual ITracker& parent() override; + ITrackerPtr findChild( NameAndLocation const& nameAndLocation ) override; + ITracker& parent() override; - virtual void openChild() override; + void openChild() override; - virtual bool isSectionTracker() const override; - virtual bool isIndexTracker() const override; + bool isSectionTracker() const override; + bool isIndexTracker() const override; void open(); - virtual void close() override; - virtual void fail() override; - virtual void markAsNeedingAnotherRun() override; + void close() override; + void fail() override; + void markAsNeedingAnotherRun() override; private: void moveToParent(); @@ -147,9 +146,8 @@ namespace TestCaseTracking { std::vector<std::string> m_filters; public: SectionTracker( NameAndLocation const& nameAndLocation, TrackerContext& ctx, ITracker* parent ); - virtual ~SectionTracker() = default; - virtual bool isSectionTracker() const override; + bool isSectionTracker() const override; static SectionTracker& acquire( TrackerContext& ctx, NameAndLocation const& nameAndLocation ); @@ -164,17 +162,15 @@ namespace TestCaseTracking { int m_index = -1; public: IndexTracker( NameAndLocation const& nameAndLocation, TrackerContext& ctx, ITracker* parent, int size ); - virtual ~IndexTracker() = default; - virtual bool isIndexTracker() const override; + bool isIndexTracker() const override; + void close() override; static IndexTracker& acquire( TrackerContext& ctx, NameAndLocation const& nameAndLocation, int size ); int index() const; void moveNext(); - - virtual void close() override; }; } // namespace TestCaseTracking diff --git a/include/reporters/catch_reporter_automake.hpp b/include/reporters/catch_reporter_automake.hpp index 7a841a1a..86eb0325 100644 --- a/include/reporters/catch_reporter_automake.hpp +++ b/include/reporters/catch_reporter_automake.hpp @@ -21,17 +21,17 @@ namespace Catch { : StreamingReporterBase( _config ) {} - virtual ~AutomakeReporter(); + ~AutomakeReporter() override; static std::string getDescription() { return "Reports test results in the format of Automake .trs files"; } - virtual void assertionStarting( AssertionInfo const& ) override {} + void assertionStarting( AssertionInfo const& ) override {} - virtual bool assertionEnded( AssertionStats const& /*_assertionStats*/ ) override { return true; } + bool assertionEnded( AssertionStats const& /*_assertionStats*/ ) override { return true; } - virtual void testCaseEnded( TestCaseStats const& _testCaseStats ) override { + void testCaseEnded( TestCaseStats const& _testCaseStats ) override { // Possible values to emit are PASS, XFAIL, SKIP, FAIL, XPASS and ERROR. stream << ":test-result: "; if (_testCaseStats.totals.assertions.allPassed()) { @@ -45,7 +45,7 @@ namespace Catch { StreamingReporterBase::testCaseEnded( _testCaseStats ); } - virtual void skipTest( TestCaseInfo const& testInfo ) override { + void skipTest( TestCaseInfo const& testInfo ) override { stream << ":test-result: SKIP " << testInfo.name << '\n'; } diff --git a/include/reporters/catch_reporter_bases.hpp b/include/reporters/catch_reporter_bases.hpp index ccb44f00..85adc18f 100644 --- a/include/reporters/catch_reporter_bases.hpp +++ b/include/reporters/catch_reporter_bases.hpp @@ -32,7 +32,7 @@ namespace Catch { CATCH_ENFORCE( DerivedT::getSupportedVerbosities().count( m_config->verbosity() ), "Verbosity level not supported by this reporter" ); } - virtual ReporterPreferences getPreferences() const override { + ReporterPreferences getPreferences() const override { return m_reporterPrefs; } @@ -40,40 +40,40 @@ namespace Catch { return { Verbosity::Normal }; } - virtual ~StreamingReporterBase() override = default; + ~StreamingReporterBase() override = default; - virtual void noMatchingTestCases(std::string const&) override {} + void noMatchingTestCases(std::string const&) override {} - virtual void testRunStarting(TestRunInfo const& _testRunInfo) override { + void testRunStarting(TestRunInfo const& _testRunInfo) override { currentTestRunInfo = _testRunInfo; } - virtual void testGroupStarting(GroupInfo const& _groupInfo) override { + void testGroupStarting(GroupInfo const& _groupInfo) override { currentGroupInfo = _groupInfo; } - virtual void testCaseStarting(TestCaseInfo const& _testInfo) override { + void testCaseStarting(TestCaseInfo const& _testInfo) override { currentTestCaseInfo = _testInfo; } - virtual void sectionStarting(SectionInfo const& _sectionInfo) override { + void sectionStarting(SectionInfo const& _sectionInfo) override { m_sectionStack.push_back(_sectionInfo); } - virtual void sectionEnded(SectionStats const& /* _sectionStats */) override { + void sectionEnded(SectionStats const& /* _sectionStats */) override { m_sectionStack.pop_back(); } - virtual void testCaseEnded(TestCaseStats const& /* _testCaseStats */) override { + void testCaseEnded(TestCaseStats const& /* _testCaseStats */) override { currentTestCaseInfo.reset(); } - virtual void testGroupEnded(TestGroupStats const& /* _testGroupStats */) override { + void testGroupEnded(TestGroupStats const& /* _testGroupStats */) override { currentGroupInfo.reset(); } - virtual void testRunEnded(TestRunStats const& /* _testRunStats */) override { + void testRunEnded(TestRunStats const& /* _testRunStats */) override { currentTestCaseInfo.reset(); currentGroupInfo.reset(); currentTestRunInfo.reset(); } - virtual void skipTest(TestCaseInfo const&) override { + void skipTest(TestCaseInfo const&) override { // Don't do anything with this by default. // It can optionally be overridden in the derived class. } |