Read-only mirrors. Development, issues and pull requests are on GitHub.

summaryrefslogtreecommitdiffhomepage
path: root/include
diff options
context:
space:
mode:
authorMartin Hořeňovský2017-07-31 12:28:13 +0200
committerMartin Hořeňovský2017-07-31 12:31:45 +0200
commit8a2ff209826a9b2f52535577c1567b26e28dfd1a (patch)
treee4beb09f2593f09e20efeac454490e0972be2a23 /include
parentd3377c791de8311333a7ebd6aa3d51fa124495d0 (diff)
downloadcatch3-8a2ff209826a9b2f52535577c1567b26e28dfd1a.tar.gz
Address some of the Resharper finds for Catch 1
Closes #957 as the other findings are mostly noise that is pointless to fix in a branch that will be soon EoLd.
Diffstat (limited to 'include')
-rw-r--r--include/internal/catch_assertionresult.h2
-rw-r--r--include/internal/catch_assertionresult.hpp2
-rw-r--r--include/internal/catch_test_spec_parser.hpp2
3 files changed, 4 insertions, 2 deletions
diff --git a/include/internal/catch_assertionresult.h b/include/internal/catch_assertionresult.h
index 5d6c86d1..39958498 100644
--- a/include/internal/catch_assertionresult.h
+++ b/include/internal/catch_assertionresult.h
@@ -39,7 +39,7 @@ namespace Catch {
struct AssertionInfo
{
- AssertionInfo() {}
+ AssertionInfo();
AssertionInfo( char const * _macroName,
SourceLineInfo const& _lineInfo,
char const * _capturedExpression,
diff --git a/include/internal/catch_assertionresult.hpp b/include/internal/catch_assertionresult.hpp
index 2fa3373d..9a9fce63 100644
--- a/include/internal/catch_assertionresult.hpp
+++ b/include/internal/catch_assertionresult.hpp
@@ -13,6 +13,8 @@
namespace Catch {
+ AssertionInfo::AssertionInfo():macroName(""), capturedExpression(""), resultDisposition(ResultDisposition::Flags::Normal), secondArg(""){}
+
AssertionInfo::AssertionInfo( char const * _macroName,
SourceLineInfo const& _lineInfo,
char const * _capturedExpression,
diff --git a/include/internal/catch_test_spec_parser.hpp b/include/internal/catch_test_spec_parser.hpp
index 05bdcf4c..055bf1dc 100644
--- a/include/internal/catch_test_spec_parser.hpp
+++ b/include/internal/catch_test_spec_parser.hpp
@@ -30,7 +30,7 @@ namespace Catch {
ITagAliasRegistry const* m_tagAliases;
public:
- TestSpecParser( ITagAliasRegistry const& tagAliases ) : m_tagAliases( &tagAliases ) {}
+ TestSpecParser( ITagAliasRegistry const& tagAliases ) :m_mode(None), m_exclusion(false), m_start(0), m_pos(0), m_tagAliases( &tagAliases ) {}
TestSpecParser& parse( std::string const& arg ) {
m_mode = None;