diff options
| author | Martin Hořeňovský | 2017-01-31 18:02:11 +0100 |
|---|---|---|
| committer | Martin Hořeňovský | 2017-01-31 18:02:11 +0100 |
| commit | 0dabd951ba115f682e387d72f7f9866de824db0b (patch) | |
| tree | 29ed55badd386ce271c23cf1f135aa95ba92752d /include | |
| parent | 7ae96c710b579f8beb58d713e0e93192755bd37d (diff) | |
| download | catch3-0dabd951ba115f682e387d72f7f9866de824db0b.tar.gz | |
expr is now cast to void in THROWS family of assertions.
This prevents Clang from complaining about unused value in expressions
containing explicit casts used in the THROW assertion macro family.
Example:
`REQUIRE_THROWS_AS(static_cast<bool>(object), std::bad_cast);` would
trigger `-Wunused-value` warning. Now it does not.
Credits to Arto Bendiken, who submitted a PR almost 3 years ago, but his
branch has since died and I was unable to merge it.
Diffstat (limited to 'include')
| -rw-r--r-- | include/internal/catch_capture.hpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/include/internal/catch_capture.hpp b/include/internal/catch_capture.hpp index 5d6a97ae..04be7016 100644 --- a/include/internal/catch_capture.hpp +++ b/include/internal/catch_capture.hpp @@ -58,7 +58,7 @@ do { \ Catch::ResultBuilder __catchResult( macroName, CATCH_INTERNAL_LINEINFO, #expr, resultDisposition ); \ try { \ - expr; \ + static_cast<void>(expr); \ __catchResult.captureResult( Catch::ResultWas::Ok ); \ } \ catch( ... ) { \ @@ -73,7 +73,7 @@ Catch::ResultBuilder __catchResult( macroName, CATCH_INTERNAL_LINEINFO, #expr, resultDisposition, #matcher ); \ if( __catchResult.allowThrows() ) \ try { \ - expr; \ + static_cast<void>(expr); \ __catchResult.captureResult( Catch::ResultWas::DidntThrowException ); \ } \ catch( ... ) { \ @@ -90,7 +90,7 @@ Catch::ResultBuilder __catchResult( macroName, CATCH_INTERNAL_LINEINFO, #expr, resultDisposition ); \ if( __catchResult.allowThrows() ) \ try { \ - expr; \ + static_cast<void>(expr); \ __catchResult.captureResult( Catch::ResultWas::DidntThrowException ); \ } \ catch( exceptionType ) { \ |