diff options
| author | Martin Hořeňovský | 2019-01-25 21:29:12 +0100 |
|---|---|---|
| committer | Martin Hořeňovský | 2019-01-25 21:29:12 +0100 |
| commit | d9e99dc2ca119792736689f66c2020dddc42cff0 (patch) | |
| tree | 4a4859fe4f0355b32e7c6419076449a283e8c550 /include | |
| parent | 804a2118c28ef895bb1487768eb3be28dfe26254 (diff) | |
| download | catch3-d9e99dc2ca119792736689f66c2020dddc42cff0.tar.gz | |
Improve explanation of why -Wparentheses suppression leaks
Related to #1508
Diffstat (limited to 'include')
| -rw-r--r-- | include/internal/catch_suppress_warnings.h | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/include/internal/catch_suppress_warnings.h b/include/internal/catch_suppress_warnings.h index 25d90125..dc8c1da2 100644 --- a/include/internal/catch_suppress_warnings.h +++ b/include/internal/catch_suppress_warnings.h @@ -16,10 +16,11 @@ # pragma clang diagnostic ignored "-Wcovered-switch-default" # endif #elif defined __GNUC__ - // GCC likes to warn on REQUIREs, and we cannot suppress them - // locally because g++'s support for _Pragma is lacking in older, - // still supported, versions -# pragma GCC diagnostic ignored "-Wparentheses" + // Because REQUIREs trigger GCC's -Wparentheses, and because still + // supported version of g++ have only buggy support for _Pragmas, + // Wparentheses have to be suppressed globally. +# pragma GCC diagnostic ignored "-Wparentheses" // See #674 for details + # pragma GCC diagnostic push # pragma GCC diagnostic ignored "-Wunused-variable" # pragma GCC diagnostic ignored "-Wpadded" |