diff options
| author | Sebastian Grottel | 2017-10-15 18:30:40 +0200 |
|---|---|---|
| committer | Martin Hořeňovský | 2017-10-31 14:26:36 +0100 |
| commit | 96c5de678d538e4e9b95c7f06afa03e3d0a0b15e (patch) | |
| tree | 4bd10df212ebad0ffa7b18cb8ffc1bbcd621ebc1 /include | |
| parent | e68485e19664d0388c98db0bb7bc8e985a3a42cd (diff) | |
| download | catch3-96c5de678d538e4e9b95c7f06afa03e3d0a0b15e.tar.gz | |
`RandomNumberGenerator::result_type` should be unsigned (#1050)
`result_type` must be unsigned:
http://en.cppreference.com/w/cpp/concept/UniformRandomBitGenerator
Using a signed type causes an infinite loop working with MS Visual Studio 2017, targetting: v140, WindowsTargetPlatformVersion 10.0.15063.0, Debug, x64
Diffstat (limited to 'include')
| -rw-r--r-- | include/internal/catch_random_number_generator.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/internal/catch_random_number_generator.h b/include/internal/catch_random_number_generator.h index 1a61202d..2395bd39 100644 --- a/include/internal/catch_random_number_generator.h +++ b/include/internal/catch_random_number_generator.h @@ -20,7 +20,7 @@ namespace Catch { unsigned int rngSeed(); struct RandomNumberGenerator { - using result_type = std::ptrdiff_t; + using result_type = unsigned int; static constexpr result_type (min)() { return 0; } static constexpr result_type (max)() { return 1000000; } |