diff options
| author | Martin Hořeňovský | 2017-09-07 16:51:33 +0200 |
|---|---|---|
| committer | Martin Hořeňovský | 2017-09-07 17:25:15 +0200 |
| commit | 9aa96712aec495d5a0d580f773c292803cc662aa (patch) | |
| tree | fa68e3b1bad433075b8254183c0cc4f9b7af624c /include/internal/catch_test_case_tracker.cpp | |
| parent | 6105282c4f74984eede1f6ab37b2340f4db19f8a (diff) | |
| download | catch3-9aa96712aec495d5a0d580f773c292803cc662aa.tar.gz | |
Sweep out some extra warnings
Swept:
`-Wpadded` in some places (where it caused extra size, instead of just
saying "hey, we padded struct at the end to align, just as standard says")
`-Wweak-vtables` everywhere (Clang)
`-Wexit-time-destructors` everywhere (Clang)
`-Wmissing-noreturn` everywhere (Clang)
The last three are enabled for Clang compilation going forward.
Also enabled `-Wunreachable-code` for Clang and GCC
Diffstat (limited to 'include/internal/catch_test_case_tracker.cpp')
| -rw-r--r-- | include/internal/catch_test_case_tracker.cpp | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/include/internal/catch_test_case_tracker.cpp b/include/internal/catch_test_case_tracker.cpp index fb3f8d44..bcb7793f 100644 --- a/include/internal/catch_test_case_tracker.cpp +++ b/include/internal/catch_test_case_tracker.cpp @@ -14,7 +14,10 @@ #include <stdexcept> #include <memory> -CATCH_INTERNAL_SUPPRESS_ETD_WARNINGS +#if defined(__clang__) +# pragma clang diagnostic push +# pragma clang diagnostic ignored "-Wexit-time-destructors" +#endif namespace Catch { namespace TestCaseTracking { @@ -25,6 +28,8 @@ namespace TestCaseTracking { {} + ITracker::~ITracker() = default; + TrackerContext& TrackerContext::instance() { static TrackerContext s_instance; @@ -276,4 +281,6 @@ using TestCaseTracking::IndexTracker; } // namespace Catch -CATCH_INTERNAL_UNSUPPRESS_ETD_WARNINGS +#if defined(__clang__) +# pragma clang diagnostic pop +#endif |