diff options
| author | Martin Hořeňovský | 2020-05-25 09:45:24 +0200 |
|---|---|---|
| committer | Martin Hořeňovský | 2020-05-31 15:20:24 +0200 |
| commit | 1d1ccf8f3c0c9e121b16afd4fafb850d14ef9fb0 (patch) | |
| tree | 0a292cf929c75743993d42453312e08888ef7c0a /examples | |
| parent | 41bbaa6d573a598fe0796fd0e391ed57eae62e30 (diff) | |
| download | catch3-1d1ccf8f3c0c9e121b16afd4fafb850d14ef9fb0.tar.gz | |
Replace all uses of std::unique_ptr with Catch::Detail::unique_ptr
Doing some benchmarking with ClangBuildAnalyzer suggests that
compiling Catch2's `SelfTest` spends 10% of the time instantiating
`std::unique_ptr` for some interface types required for registering
and running tests.
The lesser compilation overhead of `Catch::Detail::unique_ptr` should
significantly reduce that time.
The compiled implementation was also changed to use the custom impl,
to avoid having to convert between using `std::unique_ptr` and
`Catch::Detail::unique_ptr`. This will likely also improve the compile
times of the implementation, but that is less important than improving
compilation times of the user's TUs with tests.
Diffstat (limited to 'examples')
| -rw-r--r-- | examples/300-Gen-OwnGenerator.cpp | 6 | ||||
| -rw-r--r-- | examples/301-Gen-MapTypeConversion.cpp | 2 |
2 files changed, 5 insertions, 3 deletions
diff --git a/examples/300-Gen-OwnGenerator.cpp b/examples/300-Gen-OwnGenerator.cpp index bff62907..09643d6f 100644 --- a/examples/300-Gen-OwnGenerator.cpp +++ b/examples/300-Gen-OwnGenerator.cpp @@ -43,7 +43,9 @@ int const& RandomIntGenerator::get() const { // is a value-wrapper around std::unique_ptr<IGenerator<int>>. Catch::Generators::GeneratorWrapper<int> random(int low, int high) { return Catch::Generators::GeneratorWrapper<int>( - std::make_unique<RandomIntGenerator>(low, high) + new RandomIntGenerator(low, high) + // Another possibility: + // Catch::Detail::make_unique<RandomIntGenerator>(low, high) ); } @@ -58,7 +60,7 @@ TEST_CASE("Generating random ints", "[example][generator]") { REQUIRE(i <= 100); } SECTION("Creating the random generator directly") { - auto i = GENERATE(take(100, GeneratorWrapper<int>(std::unique_ptr<IGenerator<int>>(new RandomIntGenerator(-100, 100))))); + auto i = GENERATE(take(100, GeneratorWrapper<int>(Catch::Detail::make_unique<RandomIntGenerator>(-100, 100)))); REQUIRE(i >= -100); REQUIRE(i <= 100); } diff --git a/examples/301-Gen-MapTypeConversion.cpp b/examples/301-Gen-MapTypeConversion.cpp index 15b90fdd..6d81ce6d 100644 --- a/examples/301-Gen-MapTypeConversion.cpp +++ b/examples/301-Gen-MapTypeConversion.cpp @@ -40,7 +40,7 @@ std::string const& LineGenerator::get() const { // is a value-wrapper around std::unique_ptr<IGenerator<std::string>>. Catch::Generators::GeneratorWrapper<std::string> lines(std::string /* ignored for example */) { return Catch::Generators::GeneratorWrapper<std::string>( - std::make_unique<LineGenerator>() + new LineGenerator() ); } |