catch3
Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.
Clonegit clone https://git.progmasoft.com/catch3
fix compiler warning in parseUint and catch only relevant exceptions (#2572)
- Commit
e3fc97dffbad63f49a90e5ae688b0ce0c282e8c2- Author
- lbckmnn ·
- Committer
- GitHub
- Parents
9c0533a90504
Changes
src/catch2/internal/catch_parse_numbers.cpp | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/catch2/internal/catch_parse_numbers.cpp b/src/catch2/internal/catch_parse_numbers.cpp index 390b8c87..d949ac19 100644 --- a/src/catch2/internal/catch_parse_numbers.cpp +++ b/src/catch2/internal/catch_parse_numbers.cpp @@ -6,12 +6,12 @@ // SPDX-License-Identifier: BSL-1.0 -#include <catch2/internal/catch_parse_numbers.hpp> - #include <catch2/internal/catch_compiler_capabilities.hpp> +#include <catch2/internal/catch_parse_numbers.hpp> #include <catch2/internal/catch_string_manip.hpp> #include <limits> +#include <stdexcept> namespace Catch { @@ -39,11 +39,14 @@ namespace Catch { return {}; } return static_cast<unsigned int>(ret); - } CATCH_CATCH_ANON( std::exception const& ) { - // There was a larger issue with the input, e.g. the parsed - // number would be too large to fit within ull. - return {}; } + CATCH_CATCH_ANON( std::invalid_argument const& ) { + // no conversion could be performed + } + CATCH_CATCH_ANON( std::out_of_range const& ) { + // the input does not fit into an unsigned long long + } + return {}; } } // namespace Catch