Progmasoft Git

catch3

Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.

Clonegit clone https://git.progmasoft.com/catch3

Add -Wmissing-prototypes to common warnings

Commit
e2d07d35f4e31fa07fda89aadfb547e20b6b63b3
Author
Martin Hořeňovský ·
Parents
d2cb934d283b

Files · Download .tar.gz

Changes

 CMake/CatchMiscFunctions.cmake                  | 1 +
 tests/SelfTest/UsageTests/Compilation.tests.cpp | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/CMake/CatchMiscFunctions.cmake b/CMake/CatchMiscFunctions.cmake
index 2271cf27..21f4f6c0 100644
--- a/CMake/CatchMiscFunctions.cmake
+++ b/CMake/CatchMiscFunctions.cmake
@@ -64,6 +64,7 @@ function(add_warnings_to_targets targets)
           "-Wmissing-braces"
           "-Wmissing-declarations"
           "-Wmissing-noreturn"
+          "-Wmissing-prototypes"
           "-Wmissing-variable-declarations"
           "-Wnull-dereference"
           "-Wold-style-cast"
diff --git a/tests/SelfTest/UsageTests/Compilation.tests.cpp b/tests/SelfTest/UsageTests/Compilation.tests.cpp
index d45f8e6c..5d9ab3f0 100644
--- a/tests/SelfTest/UsageTests/Compilation.tests.cpp
+++ b/tests/SelfTest/UsageTests/Compilation.tests.cpp
@@ -26,7 +26,7 @@ namespace bar {
 #ifdef __GNUC__
 #pragma GCC diagnostic ignored "-Wmissing-declarations"
 #endif
-std::ostream& operator<<(std::ostream& out, foo::helper_1403 const&) {
+static std::ostream& operator<<(std::ostream& out, foo::helper_1403 const&) {
     return out << "[1403 helper]";
 }
 ///////////////////////////////
@@ -49,7 +49,7 @@ struct logic_t {
 };
 
 
-void throws_int(bool b) {
+static void throws_int(bool b) {
     if (b) {
         throw 1;
     }
@@ -69,7 +69,7 @@ bool templated_tests(T t) {
 
 struct A {};
 
-std::ostream &operator<<(std::ostream &o, const A &) { return o << 0; }
+static std::ostream &operator<<(std::ostream &o, const A &) { return o << 0; }
 
 struct B : private A {
     bool operator==(int) const { return true; }