catch3
Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.
Clonegit clone https://git.progmasoft.com/catch3
Improve explanation of why -Wparentheses suppression leaks
- Commit
d9e99dc2ca119792736689f66c2020dddc42cff0- Author
- Martin Hořeňovský ·
- Parents
804a2118c28e
Changes
include/internal/catch_suppress_warnings.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/internal/catch_suppress_warnings.h b/include/internal/catch_suppress_warnings.h index 25d90125..dc8c1da2 100644 --- a/include/internal/catch_suppress_warnings.h +++ b/include/internal/catch_suppress_warnings.h @@ -16,10 +16,11 @@ # pragma clang diagnostic ignored "-Wcovered-switch-default" # endif #elif defined __GNUC__ - // GCC likes to warn on REQUIREs, and we cannot suppress them - // locally because g++'s support for _Pragma is lacking in older, - // still supported, versions -# pragma GCC diagnostic ignored "-Wparentheses" + // Because REQUIREs trigger GCC's -Wparentheses, and because still + // supported version of g++ have only buggy support for _Pragmas, + // Wparentheses have to be suppressed globally. +# pragma GCC diagnostic ignored "-Wparentheses" // See #674 for details + # pragma GCC diagnostic push # pragma GCC diagnostic ignored "-Wunused-variable" # pragma GCC diagnostic ignored "-Wpadded"