Progmasoft Git

catch3

Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.

Clonegit clone https://git.progmasoft.com/catch3

added version of Clara that has virtual destructors

(just to silence warnings - they are not actually needed)
Commit
d81c1eb00699e469d13b998c222a929d121cb0d1
Author
philsquared ·
Parents
da5964af782f

Files · Download .tar.gz

Changes

 include/external/clara.hpp | 2 ++
 third_party/clara.hpp      | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/include/external/clara.hpp b/include/external/clara.hpp
index b2eced66..03fdf298 100644
--- a/include/external/clara.hpp
+++ b/include/external/clara.hpp
@@ -480,6 +480,7 @@ namespace detail {
 
     protected:
         ResultBase(Type type) : m_type(type) {}
+        virtual ~ResultBase() = default;
 
         virtual void enforceOk() const = 0;
 
@@ -782,6 +783,7 @@ namespace detail {
 
     class ParserBase {
     public:
+        virtual ~ParserBase() = default;
         virtual auto validate() const -> Result { return Result::ok(); }
 
         virtual auto parse( std::string const& exeName, TokenStream const &tokens) const -> InternalParseResult  = 0;
diff --git a/third_party/clara.hpp b/third_party/clara.hpp
index 5455e5af..5ee18df1 100644
--- a/third_party/clara.hpp
+++ b/third_party/clara.hpp
@@ -477,6 +477,7 @@ namespace detail {
 
     protected:
         ResultBase(Type type) : m_type(type) {}
+        virtual ~ResultBase() = default;
 
         virtual void enforceOk() const = 0;
 
@@ -779,6 +780,7 @@ namespace detail {
 
     class ParserBase {
     public:
+        virtual ~ParserBase() = default;
         virtual auto validate() const -> Result { return Result::ok(); }
 
         virtual auto parse( std::string const& exeName, TokenStream const &tokens) const -> InternalParseResult  = 0;