Progmasoft Git

catch3

Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.

Clonegit clone https://git.progmasoft.com/catch3

Fixed mssing virtual destructor warnings

In Visual Studio with warning 4265 enabled
Closes #844
Commit
d5a5883a10918d0f2c9aed5c8c18b33a7f271b0f
Author
philsquared ·
Parents
6fea473414fa

Files · Download .tar.gz

Changes

 include/internal/catch_impl.hpp     | 1 +
 include/internal/catch_matchers.hpp | 1 +
 2 files changed, 2 insertions(+)

diff --git a/include/internal/catch_impl.hpp b/include/internal/catch_impl.hpp
index 3886136e..ed037a07 100644
--- a/include/internal/catch_impl.hpp
+++ b/include/internal/catch_impl.hpp
@@ -91,6 +91,7 @@ namespace Catch {
     TestSpec::NamePattern::~NamePattern() {}
     TestSpec::TagPattern::~TagPattern() {}
     TestSpec::ExcludedPattern::~ExcludedPattern() {}
+	Matchers::Impl::MatcherUntypedBase::~MatcherUntypedBase() {}
 
     void Config::dummy() {}
 
diff --git a/include/internal/catch_matchers.hpp b/include/internal/catch_matchers.hpp
index de7d64c7..e258caa5 100644
--- a/include/internal/catch_matchers.hpp
+++ b/include/internal/catch_matchers.hpp
@@ -27,6 +27,7 @@ namespace Matchers {
             }
 
         protected:
+			virtual ~MatcherUntypedBase();
             virtual std::string describe() const = 0;
             mutable std::string m_cachedToString;
         private: