catch3
Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.
Clonegit clone https://git.progmasoft.com/catch3
Minor clean-ups in string conversion code
- Commit
cd6f6c021afbd8b45de825164259fe6ce110df7d- Author
- Phil Nash ·
- Parents
b0e3f45a22d4
Changes
include/internal/catch_tostring.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/internal/catch_tostring.h b/include/internal/catch_tostring.h index 2828be1a..23bfa0f2 100644 --- a/include/internal/catch_tostring.h +++ b/include/internal/catch_tostring.h @@ -35,6 +35,9 @@ namespace Catch { using ::operator<<; namespace Detail { + + extern const std::string unprintableString; + std::string rawMemoryToString( const void *object, std::size_t size ); template<typename T> @@ -64,7 +67,7 @@ namespace Catch { static typename std::enable_if<::Catch::Detail::IsStreamInsertable<Fake>::value, std::string>::type convert(const Fake& t) { - std::stringstream sstr; + std::ostringstream sstr; sstr << t; return sstr.str(); } @@ -73,14 +76,12 @@ namespace Catch { static typename std::enable_if<!::Catch::Detail::IsStreamInsertable<Fake>::value, std::string>::type convert(const Fake&) { - return "{?}"; + return Detail::unprintableString; } }; namespace Detail { - extern const std::string unprintableString; - // This function dispatches all stringification requests inside of Catch. // Should be preferably called fully qualified, like ::Catch::Detail::stringify template <typename T>