catch3
Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.
Clonegit clone https://git.progmasoft.com/catch3
CumulativeReporterBase doesn't use shared_ptrs for sectionStack
- Commit
bfe5553416609372655e76bc8849d2c6ce4c2705- Author
- Martin Hořeňovský ·
- Parents
c673db7a4ec2
Changes
src/catch2/reporters/catch_reporter_cumulative_base.cpp | 2 +- src/catch2/reporters/catch_reporter_cumulative_base.hpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/catch2/reporters/catch_reporter_cumulative_base.cpp b/src/catch2/reporters/catch_reporter_cumulative_base.cpp index 67154d95..5a25ab9b 100644 --- a/src/catch2/reporters/catch_reporter_cumulative_base.cpp +++ b/src/catch2/reporters/catch_reporter_cumulative_base.cpp @@ -57,7 +57,7 @@ namespace Catch { } m_deepestSection = node.get(); - m_sectionStack.push_back( std::move(node) ); + m_sectionStack.push_back( node.get() ); } bool CumulativeReporterBase::assertionEnded( diff --git a/src/catch2/reporters/catch_reporter_cumulative_base.hpp b/src/catch2/reporters/catch_reporter_cumulative_base.hpp index 94b4c589..7f228420 100644 --- a/src/catch2/reporters/catch_reporter_cumulative_base.hpp +++ b/src/catch2/reporters/catch_reporter_cumulative_base.hpp @@ -80,7 +80,7 @@ namespace Catch { std::shared_ptr<SectionNode> m_rootSection; SectionNode* m_deepestSection = nullptr; - std::vector<std::shared_ptr<SectionNode>> m_sectionStack; + std::vector<SectionNode*> m_sectionStack; }; } // end namespace Catch