Progmasoft Git

catch3

Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.

Clonegit clone https://git.progmasoft.com/catch3

Changed use of strncpy to memcpy

Commit
a36395e2ff9b6cd283fedde1b93da4792740706a
Author
Phil Nash ·
Parents
699e57140095

Files · Download .tar.gz

Changes

 include/internal/catch_stringref.cpp | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/include/internal/catch_stringref.cpp b/include/internal/catch_stringref.cpp
index f6a1fc2a..e22b6c94 100644
--- a/include/internal/catch_stringref.cpp
+++ b/include/internal/catch_stringref.cpp
@@ -7,11 +7,9 @@
 
 #include "catch_stringref.h"
 
-#include <cstring>
 #include <ostream>
 #include <cassert>
-
-#define _CRT_SECURE_NO_WARNINGS // Suppress warnings from MSVC about strncpy not being secure
+#include <cstring>
 
 namespace Catch {
 
@@ -95,7 +93,7 @@ namespace Catch {
     void StringRef::takeOwnership() {
         if( !isOwned() ) {
             m_data = new char[m_size+1];
-            strncpy( m_data, m_start, m_size );
+            memcpy( m_data, m_start, m_size );
             m_data[m_size] = '\0';
             m_start = m_data;
         }