Make the start lock a never-destroyed objectfeature/per-test-coverage

A function-local static std::mutex has an exit-time destructor, which
the macOS build rejects with -Wexit-time-destructors. The lock is now
allocated once and never destroyed, which also keeps it usable by a
thread that starts a child while the process exits.

2 files changed, 8 insertions, 4 deletions

diff --git a/extras/catch_amalgamated.cpp b/extras/catch_amalgamated.cpp
index 7a1c9541..4b928849 100644
--- a/extras/catch_amalgamated.cpp
+++ b/extras/catch_amalgamated.cpp
@@ -16292,8 +16292,10 @@ namespace Progmasoft::Catch3::Runner
         std::mutex &
         StartLock()
         {
-            static std::mutex lock;
-            return lock;
+            // Never destroyed, so no exit-time destructor runs while a
+            // detached thread may still start a child.
+            static std::mutex *const lock = new std::mutex;
+            return *lock;
         }
     } // namespace
 
diff --git a/src/Progmasoft/Runner/Process.cpp b/src/Progmasoft/Runner/Process.cpp
index 41fa87f1..e3b0997b 100644
--- a/src/Progmasoft/Runner/Process.cpp
+++ b/src/Progmasoft/Runner/Process.cpp
@@ -621,8 +621,10 @@ namespace Progmasoft::Catch3::Runner
         std::mutex &
         StartLock()
         {
-            static std::mutex lock;
-            return lock;
+            // Never destroyed, so no exit-time destructor runs while a
+            // detached thread may still start a child.
+            static std::mutex *const lock = new std::mutex;
+            return *lock;
         }
     } // namespace