Read-only mirrors. Development, issues and pull requests are on GitHub.

summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorMartin Hořeňovský2023-02-20 15:02:41 +0100
committerMartin Hořeňovský2023-02-20 15:02:50 +0100
commit2befd98da2b91c705de8fb0ea27bff662041f51c (patch)
tree7e36eb26febe4637d7b163f964867a625711df9b
parent00f259aeb2fa292ccf5e4a9c3e15d6b4416a06b2 (diff)
downloadcatch3-2befd98da2b91c705de8fb0ea27bff662041f51c.tar.gz
Inline some non-virtual functions in ITracker and TrackerContext
-rw-r--r--src/catch2/internal/catch_test_case_tracker.cpp15
-rw-r--r--src/catch2/internal/catch_test_case_tracker.hpp13
2 files changed, 9 insertions, 19 deletions
diff --git a/src/catch2/internal/catch_test_case_tracker.cpp b/src/catch2/internal/catch_test_case_tracker.cpp
index 4bee49d6..a9d6614f 100644
--- a/src/catch2/internal/catch_test_case_tracker.cpp
+++ b/src/catch2/internal/catch_test_case_tracker.cpp
@@ -51,10 +51,6 @@ namespace TestCaseTracking {
bool ITracker::isSectionTracker() const { return false; }
bool ITracker::isGeneratorTracker() const { return false; }
- bool ITracker::isSuccessfullyCompleted() const {
- return m_runState == CompletedSuccessfully;
- }
-
bool ITracker::isOpen() const {
return m_runState != NotStarted && !isComplete();
}
@@ -81,10 +77,6 @@ namespace TestCaseTracking {
return *m_rootTracker;
}
- void TrackerContext::startCycle() {
- m_currentTracker = m_rootTracker.get();
- m_runState = Executing;
- }
void TrackerContext::completeCycle() {
m_runState = CompletedCycle;
}
@@ -92,9 +84,6 @@ namespace TestCaseTracking {
bool TrackerContext::completedCycle() const {
return m_runState == CompletedCycle;
}
- ITracker& TrackerContext::currentTracker() {
- return *m_currentTracker;
- }
void TrackerContext::setCurrentTracker( ITracker* tracker ) {
m_currentTracker = tracker;
}
@@ -232,10 +221,6 @@ namespace TestCaseTracking {
m_filters.insert( m_filters.end(), filters.begin()+1, filters.end() );
}
- std::vector<StringRef> const& SectionTracker::getFilters() const {
- return m_filters;
- }
-
StringRef SectionTracker::trimmedName() const {
return m_trimmed_name;
}
diff --git a/src/catch2/internal/catch_test_case_tracker.hpp b/src/catch2/internal/catch_test_case_tracker.hpp
index 148719e3..8252558a 100644
--- a/src/catch2/internal/catch_test_case_tracker.hpp
+++ b/src/catch2/internal/catch_test_case_tracker.hpp
@@ -105,7 +105,9 @@ namespace TestCaseTracking {
//! Returns true if tracker run to completion (successfully or not)
virtual bool isComplete() const = 0;
//! Returns true if tracker run to completion succesfully
- bool isSuccessfullyCompleted() const;
+ bool isSuccessfullyCompleted() const {
+ return m_runState == CompletedSuccessfully;
+ }
//! Returns true if tracker has started but hasn't been completed
bool isOpen() const;
//! Returns true iff tracker has started
@@ -165,11 +167,14 @@ namespace TestCaseTracking {
ITracker& startRun();
- void startCycle();
+ void startCycle() {
+ m_currentTracker = m_rootTracker.get();
+ m_runState = Executing;
+ }
void completeCycle();
bool completedCycle() const;
- ITracker& currentTracker();
+ ITracker& currentTracker() { return *m_currentTracker; }
void setCurrentTracker( ITracker* tracker );
};
@@ -214,7 +219,7 @@ namespace TestCaseTracking {
void addInitialFilters( std::vector<std::string> const& filters );
void addNextFilters( std::vector<StringRef> const& filters );
//! Returns filters active in this tracker
- std::vector<StringRef> const& getFilters() const;
+ std::vector<StringRef> const& getFilters() const { return m_filters; }
//! Returns whitespace-trimmed name of the tracked section
StringRef trimmedName() const;
};