Read-only mirrors. Development, issues and pull requests are on GitHub.

summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorHolger Kaelberer2023-04-19 10:28:45 +0200
committerMartin Hořeňovský2023-04-20 14:53:03 +0200
commit10596b22781f03df3d35f34187213f6f8709e453 (patch)
treea79191fcb1905737cde2a715c54338f9eb1784ac
parent897fe2a01b7e1983b076ef41f4ce11c5b3e498c6 (diff)
downloadcatch3-10596b22781f03df3d35f34187213f6f8709e453.tar.gz
Fix unreachable-code-return warnings
-rw-r--r--src/catch2/internal/catch_reporter_registry.cpp2
-rw-r--r--tests/SelfTest/UsageTests/Exception.tests.cpp2
2 files changed, 1 insertions, 3 deletions
diff --git a/src/catch2/internal/catch_reporter_registry.cpp b/src/catch2/internal/catch_reporter_registry.cpp
index 8f13ae56..b2b0cd07 100644
--- a/src/catch2/internal/catch_reporter_registry.cpp
+++ b/src/catch2/internal/catch_reporter_registry.cpp
@@ -57,8 +57,6 @@ namespace Catch {
auto it = m_impl->factories.find( name );
if ( it == m_impl->factories.end() ) return nullptr;
return it->second->create( CATCH_MOVE( config ) );
-
- return IEventListenerPtr();
}
void ReporterRegistry::registerReporter( std::string const& name,
diff --git a/tests/SelfTest/UsageTests/Exception.tests.cpp b/tests/SelfTest/UsageTests/Exception.tests.cpp
index f917932f..4f91a30c 100644
--- a/tests/SelfTest/UsageTests/Exception.tests.cpp
+++ b/tests/SelfTest/UsageTests/Exception.tests.cpp
@@ -20,7 +20,7 @@
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wweak-vtables"
#pragma clang diagnostic ignored "-Wmissing-noreturn"
-#pragma clang diagnostic ignored "-Wunreachable-code"
+#pragma clang diagnostic ignored "-Wunreachable-code-return"
#endif
namespace {