diff options
| author | itacud95 | 2024-02-20 00:32:12 +0100 |
|---|---|---|
| committer | GitHub | 2024-02-20 00:32:12 +0100 |
| commit | 024cfb354211b40e368a66c40054d8881e26b8a8 (patch) | |
| tree | 93a2a91055e74df4dc979912db3a1e9aceeb1060 | |
| parent | 28c2f0b0c2f2793f2432b55bd14282aaadd7509f (diff) | |
| download | catch3-024cfb354211b40e368a66c40054d8881e26b8a8.tar.gz | |
Link Android's `log` with PRIVATE visibility (#2815)
INTERFACE should be used on dependencies from other than our source files.
PRIVATE should be used the include happens in our source files.
In this case (src/catch2/internal/catch_debug_console.cpp:20) the include
is from our source file.
I encountered a issue with this when building Catch2 for Android in
combination with BUILD_SHARED_LIBS. Changing the visibility to PRIVATE
fixes the issue.
| -rw-r--r-- | src/CMakeLists.txt | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index eb805ddd..0b200425 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -354,7 +354,7 @@ endif() add_library(Catch2::Catch2 ALIAS Catch2) if (ANDROID) - target_link_libraries(Catch2 INTERFACE log) + target_link_libraries(Catch2 PRIVATE log) endif() set_target_properties(Catch2 PROPERTIES |