Progmasoft Git

catch3

Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.

Clonegit clone https://git.progmasoft.com/catch3

Move all<int> to .cpp file to remove <limits> from common path

Commit
92e25049cf94574a8d344beb904cd2f75ffb5fc8
Author
Martin Hořeňovský ·
Parents
fdcd46420e1f

Files · Download .tar.gz

Changes

 include/internal/catch_generators.cpp | 5 +++++
 include/internal/catch_generators.hpp | 9 +++------
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/include/internal/catch_generators.cpp b/include/internal/catch_generators.cpp
index caf5a0df..786da736 100644
--- a/include/internal/catch_generators.cpp
+++ b/include/internal/catch_generators.cpp
@@ -9,6 +9,7 @@
 #include "catch_random_number_generator.h"
 #include "catch_interfaces_capture.h"
 
+#include <limits>
 #include <set>
 
 namespace Catch {
@@ -40,6 +41,10 @@ namespace Generators {
         return getResultCapture().acquireGeneratorTracker( lineInfo );
     }
 
+    template<>
+    auto all<int>() -> Generator<int> {
+        return range( std::numeric_limits<int>::min(), std::numeric_limits<int>::max() );
+    }
 
 } // namespace Generators
 } // namespace Catch
diff --git a/include/internal/catch_generators.hpp b/include/internal/catch_generators.hpp
index 26a310c2..74fa5922 100644
--- a/include/internal/catch_generators.hpp
+++ b/include/internal/catch_generators.hpp
@@ -13,7 +13,6 @@
 #include <memory>
 #include <vector>
 #include <cassert>
-#include <limits>
 
 #include <utility>
 
@@ -123,16 +122,14 @@ namespace Generators {
     template<typename T>
     auto all() -> Generator<T> { return RequiresASpecialisationFor<T>(); }
 
+    template<>
+    auto all<int>() -> Generator<int>;
+
 
     template<typename T>
     auto range( T const& first, T const& last ) -> Generator<T> {
         return Generator<T>( (last-first), pf::make_unique<RangeGenerator<T>>( first, last ) );
     }
-    template<>
-    inline auto all<int>() -> Generator<int> {
-        return range( std::numeric_limits<int>::min(), std::numeric_limits<int>::max()-1 );
-    }
-
 
     template<typename T>
     auto random( T const& first, T const& last ) -> Generator<T> {