Progmasoft Git

catch3

Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.

Clonegit clone https://git.progmasoft.com/catch3

Unvirtual bunch off destructors of simple data classes

Commit
7c622a79d4d3b8d0a2ae8ab4f6a9b4007bb53181
Author
Martin Hořeňovský ·
Parents
04cbbb8a4b2c

Files · Download .tar.gz

Changes

 src/catch2/interfaces/catch_interfaces_reporter.cpp | 9 ---------
 src/catch2/interfaces/catch_interfaces_reporter.hpp | 5 -----
 2 files changed, 14 deletions(-)

diff --git a/src/catch2/interfaces/catch_interfaces_reporter.cpp b/src/catch2/interfaces/catch_interfaces_reporter.cpp
index f0e612e7..29bbb200 100644
--- a/src/catch2/interfaces/catch_interfaces_reporter.cpp
+++ b/src/catch2/interfaces/catch_interfaces_reporter.cpp
@@ -57,8 +57,6 @@ namespace Catch {
         }
     }
 
-     AssertionStats::~AssertionStats() = default;
-
     SectionStats::SectionStats(  SectionInfo const& _sectionInfo,
                                  Counts const& _assertions,
                                  double _durationInSeconds,
@@ -69,8 +67,6 @@ namespace Catch {
         missingAssertions( _missingAssertions )
     {}
 
-    SectionStats::~SectionStats() = default;
-
 
     TestCaseStats::TestCaseStats(  TestCaseInfo const& _testInfo,
                                    Totals const& _totals,
@@ -84,8 +80,6 @@ namespace Catch {
         aborting( _aborting )
     {}
 
-    TestCaseStats::~TestCaseStats() = default;
-
 
     TestGroupStats::TestGroupStats( GroupInfo const& _groupInfo,
                                     Totals const& _totals,
@@ -100,7 +94,6 @@ namespace Catch {
         aborting( false )
     {}
 
-    TestGroupStats::~TestGroupStats() = default;
 
     TestRunStats::TestRunStats(   TestRunInfo const& _runInfo,
                     Totals const& _totals,
@@ -110,8 +103,6 @@ namespace Catch {
         aborting( _aborting )
     {}
 
-    TestRunStats::~TestRunStats() = default;
-
     void IStreamingReporter::fatalErrorEncountered( StringRef ) {}
 
     void IStreamingReporter::listReporters(std::vector<ReporterDescription> const& descriptions, Config const& config) {
diff --git a/src/catch2/interfaces/catch_interfaces_reporter.hpp b/src/catch2/interfaces/catch_interfaces_reporter.hpp
index 01469999..d6c29810 100644
--- a/src/catch2/interfaces/catch_interfaces_reporter.hpp
+++ b/src/catch2/interfaces/catch_interfaces_reporter.hpp
@@ -88,7 +88,6 @@ namespace Catch {
         AssertionStats( AssertionStats && )                  = default;
         AssertionStats& operator = ( AssertionStats const& ) = delete;
         AssertionStats& operator = ( AssertionStats && )     = delete;
-        virtual ~AssertionStats();
 
         AssertionResult assertionResult;
         std::vector<MessageInfo> infoMessages;
@@ -104,7 +103,6 @@ namespace Catch {
         SectionStats( SectionStats && )                  = default;
         SectionStats& operator = ( SectionStats const& ) = default;
         SectionStats& operator = ( SectionStats && )     = default;
-        virtual ~SectionStats();
 
         SectionInfo sectionInfo;
         Counts assertions;
@@ -123,7 +121,6 @@ namespace Catch {
         TestCaseStats( TestCaseStats && )                  = default;
         TestCaseStats& operator = ( TestCaseStats const& ) = default;
         TestCaseStats& operator = ( TestCaseStats && )     = default;
-        virtual ~TestCaseStats();
 
         TestCaseInfo const * testInfo;
         Totals totals;
@@ -142,7 +139,6 @@ namespace Catch {
         TestGroupStats( TestGroupStats && )                  = default;
         TestGroupStats& operator = ( TestGroupStats const& ) = default;
         TestGroupStats& operator = ( TestGroupStats && )     = default;
-        virtual ~TestGroupStats();
 
         GroupInfo groupInfo;
         Totals totals;
@@ -158,7 +154,6 @@ namespace Catch {
         TestRunStats( TestRunStats && )                  = default;
         TestRunStats& operator = ( TestRunStats const& ) = default;
         TestRunStats& operator = ( TestRunStats && )     = default;
-        virtual ~TestRunStats();
 
         TestRunInfo runInfo;
         Totals totals;