catch3
Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.
Clonegit clone https://git.progmasoft.com/catch3
Prevent compilation of generators that use bool in dangerous manner
- Commit
53281b471f881b86d1ed037b3df0c239287552af- Author
- Martin Hořeňovský ·
- Parents
03ffc1014cb8
Changes
include/internal/catch_generators.hpp | 3 +++ include/internal/catch_generators_generic.hpp | 3 +++ 2 files changed, 6 insertions(+) diff --git a/include/internal/catch_generators.hpp b/include/internal/catch_generators.hpp index 8f06b8c6..883fd85b 100644 --- a/include/internal/catch_generators.hpp +++ b/include/internal/catch_generators.hpp @@ -70,6 +70,9 @@ namespace Generators { template<typename T> class FixedValuesGenerator final : public IGenerator<T> { + static_assert(!std::is_same<T, bool>::value, + "ValuesGenerator does not support bools because of std::vector<bool>" + "specialization, use SingleValue Generator instead."); std::vector<T> m_values; size_t m_idx = 0; public: diff --git a/include/internal/catch_generators_generic.hpp b/include/internal/catch_generators_generic.hpp index fa3749c3..81fd3857 100644 --- a/include/internal/catch_generators_generic.hpp +++ b/include/internal/catch_generators_generic.hpp @@ -91,6 +91,9 @@ namespace Generators { template <typename T> class RepeatGenerator : public IGenerator<T> { + static_assert(!std::is_same<T, bool>::value, + "RepeatGenerator currently does not support bools" + "because of std::vector<bool> specialization"); GeneratorWrapper<T> m_generator; mutable std::vector<T> m_returned; size_t m_target_repeats;