Progmasoft Git

catch3

Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.

Clonegit clone https://git.progmasoft.com/catch3

Don't use shared_ptr to store test run info in CumulativeReporterBase

Part of #2089
Commit
4f14922aa38f88ad5135c169cdf1b723cdfd26ea
Author
Martin Hořeňovský ·
Parents
0fa133a0c5e0

Files · Download .tar.gz

Changes

 src/catch2/reporters/catch_reporter_cumulative_base.cpp | 4 ++--
 src/catch2/reporters/catch_reporter_cumulative_base.hpp | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/catch2/reporters/catch_reporter_cumulative_base.cpp b/src/catch2/reporters/catch_reporter_cumulative_base.cpp
index dabf1a4e..dcb57fc2 100644
--- a/src/catch2/reporters/catch_reporter_cumulative_base.cpp
+++ b/src/catch2/reporters/catch_reporter_cumulative_base.cpp
@@ -105,9 +105,9 @@ namespace Catch {
     }
 
     void CumulativeReporterBase::testRunEnded( TestRunStats const& testRunStats ) {
-        auto node = std::make_shared<TestRunNode>( testRunStats );
+        auto node = Detail::make_unique<TestRunNode>( testRunStats );
         node->children.swap( m_testGroups );
-        m_testRuns.push_back( node );
+        m_testRuns.push_back( std::move(node) );
         testRunEndedCumulative();
     }
 
diff --git a/src/catch2/reporters/catch_reporter_cumulative_base.hpp b/src/catch2/reporters/catch_reporter_cumulative_base.hpp
index 2f5fa5fb..8897523e 100644
--- a/src/catch2/reporters/catch_reporter_cumulative_base.hpp
+++ b/src/catch2/reporters/catch_reporter_cumulative_base.hpp
@@ -9,6 +9,7 @@
 #define CATCH_REPORTER_CUMULATIVE_BASE_HPP_INCLUDED
 
 #include <catch2/interfaces/catch_interfaces_reporter.hpp>
+#include <catch2/internal/catch_unique_ptr.hpp>
 
 #include <iosfwd>
 #include <memory>
@@ -77,7 +78,7 @@ namespace Catch {
         std::vector<std::shared_ptr<TestCaseNode>> m_testCases;
         std::vector<std::shared_ptr<TestGroupNode>> m_testGroups;
 
-        std::vector<std::shared_ptr<TestRunNode>> m_testRuns;
+        std::vector<Detail::unique_ptr<TestRunNode>> m_testRuns;
 
         std::shared_ptr<SectionNode> m_rootSection;
         std::shared_ptr<SectionNode> m_deepestSection;