catch3
Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.
Clonegit clone https://git.progmasoft.com/catch3
Add full set of constraints to random integral generator
- Commit
4142e699c2d970ee039bb1cfd406401f7d94393e- Author
- Martin Hořeňovský ·
- Parents
9e445930cc22
Changes
src/catch2/generators/catch_generators_random.hpp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/catch2/generators/catch_generators_random.hpp b/src/catch2/generators/catch_generators_random.hpp index 15043211..8b2c4949 100644 --- a/src/catch2/generators/catch_generators_random.hpp +++ b/src/catch2/generators/catch_generators_random.hpp @@ -65,12 +65,17 @@ public: } }; -// TODO: Ideally this would be also constrained against the various char types, -// but I don't expect users to run into that in practice. template <typename T> -std::enable_if_t<std::is_integral<T>::value && !std::is_same<T, bool>::value, -GeneratorWrapper<T>> +std::enable_if_t<std::is_integral<T>::value, GeneratorWrapper<T>> random(T a, T b) { + static_assert( + !std::is_same<T, char>::value && + !std::is_same<T, uint8_t>::value && + !std::is_same<T, uint8_t>::value && + !std::is_same<T, signed char>::value && + !std::is_same<T, unsigned char>::value && + !std::is_same<T, bool>::value, + "The requested type is not supported by the underlying random distributions from std" ); return GeneratorWrapper<T>( Catch::Detail::make_unique<RandomIntegerGenerator<T>>(a, b, Detail::getSeed()) );