Progmasoft Git

catch3

Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results.

Clonegit clone https://git.progmasoft.com/catch3

Remove XmlWriter::writeBlankLine

There is no good reason to provide a "add empty line" primitive
for writing XML documents, and the fact that it remains unused
after all the time it was provided only confirms this further.
Commit
3e9c6fec222a5b307a712ba47dc4e930b37ad4e5
Author
Martin Hořeňovský ·
Parents
13670f535fad

Files · Download .tar.gz

Changes

 src/catch2/internal/catch_xmlwriter.cpp | 6 ------
 src/catch2/internal/catch_xmlwriter.hpp | 2 --
 2 files changed, 8 deletions(-)

diff --git a/src/catch2/internal/catch_xmlwriter.cpp b/src/catch2/internal/catch_xmlwriter.cpp
index 1be19bfc..3aecd04a 100644
--- a/src/catch2/internal/catch_xmlwriter.cpp
+++ b/src/catch2/internal/catch_xmlwriter.cpp
@@ -322,12 +322,6 @@ namespace {
         m_os << R"(<?xml-stylesheet type="text/xsl" href=")" << url << R"("?>)" << '\n';
     }
 
-    XmlWriter& XmlWriter::writeBlankLine() {
-        ensureTagClosed();
-        m_os << '\n';
-        return *this;
-    }
-
     void XmlWriter::ensureTagClosed() {
         if( m_tagIsOpen ) {
             m_os << '>' << std::flush;
diff --git a/src/catch2/internal/catch_xmlwriter.hpp b/src/catch2/internal/catch_xmlwriter.hpp
index a939a6f3..7bfa2c39 100644
--- a/src/catch2/internal/catch_xmlwriter.hpp
+++ b/src/catch2/internal/catch_xmlwriter.hpp
@@ -129,8 +129,6 @@ namespace Catch {
 
         void writeStylesheetRef( StringRef url );
 
-        XmlWriter& writeBlankLine();
-
         void ensureTagClosed();
 
     private: