catch3/src, branch remove_redundant_destructors Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results. Remove redundant destructors 2023-12-31T01:56:54+00:00 Chris Thrasher 2023-12-28T22:39:19+00:00 a5245ac76b18beae4a5b6ed62bbf4ae0194b457c Classes will automatically inherit the virtual-ness of their base class destructors. If the base class already has a virtual destructor and the derived class needs default destructor semantics then the derived class can omit defining the destructor in favor of the compiler automatically defining it. This has an additional benefit of reenabling move semantics. The presence of a user-specified destructor automatically disables move operations. 
Classes will automatically inherit the virtual-ness of their base
class destructors. If the base class already has a virtual
destructor and the derived class needs default destructor semantics
then the derived class can omit defining the destructor in favor of
the compiler automatically defining it.

This has an additional benefit of reenabling move semantics. The
presence of a user-specified destructor automatically disables move
operations.
Handle linking to liblog when [cross] building for Android using meson. (#2784) 2023-12-28T22:40:42+00:00 影月 零 2023-12-28T22:40:42+00:00 c8262e1f40c8308a47ff22ad92286f4c3c54425d * Alter meson for Android cross builds. * Handle liblog linking on Termux as well as the Android NDK. 
* Alter meson for Android cross builds.

* Handle liblog linking on Termux as well as the Android NDK.
 Merge pull request #2785 from jpalus/optional-reproducible-build 2023-12-28T20:20:41+00:00 Martin Hořeňovský 2023-12-28T20:20:41+00:00 08bdd43fcd8987c922c26a32e690bffc78d3c463 Make compiler flags for reproducible builds optional 
Make compiler flags for reproducible builds optional
 Make compiler flags for reproducible builds optional 2023-12-27T23:41:54+00:00 Jan Palus 2023-12-27T23:41:54+00:00 1512dac7e4c2fddadcc15f7ab316ce3d5b67e7f3 no change in default behavior: -ffile-prefix-map is still added if supported by compiler but add option for disabling it as it breaks generic tools for extracting debuginfo/debugsource from build artifacts like: https://sourceware.org/git/?p=debugedit.git;a=blob;f=scripts/find-debuginfo.in 
no change in default behavior: -ffile-prefix-map is still added if
supported by compiler but add option for disabling it as it breaks
generic tools for extracting debuginfo/debugsource from build artifacts
like: https://sourceware.org/git/?p=debugedit.git;a=blob;f=scripts/find-debuginfo.in
Move-enable various parts of TextFlow 2023-12-27T20:43:49+00:00 Martin Hořeňovský 2023-12-27T20:43:40+00:00 b52d97855d794175e69abc6f0eceee9ec3c1bd0e This removes about 200 pointless copies from printing the help message (the original motivation for the change), and also nicely improves performance of the various reporters that depend on TextFlow. 
This removes about 200 pointless copies from printing the help
message (the original motivation for the change), and also nicely
improves performance of the various reporters that depend on
TextFlow.
Avoid copying TokenStreams while parsing 2023-12-27T20:14:12+00:00 Martin Hořeňovský 2023-12-27T20:11:34+00:00 eaafd076743407e930a11297425f33c1f78220b0 The code is now even worse mess than before, due to the ad-hoc implementation of Result-ish type based on virtual functions in Clara, but it has dropped the allocations for empty binary down to 151. 
The code is now even worse mess than before, due to the ad-hoc
implementation of Result-ish type based on virtual functions in
Clara, but it has dropped the allocations for empty binary down
to 151.
Args and TokenStream use StringRefs instead of std::strings 2023-12-27T15:24:33+00:00 Martin Hořeňovský 2023-12-27T15:19:49+00:00 5d637d4c6b72dc21e2e198894ba0527729fba535 Because TokenStream is copied around a lot, moving it to use `StringRef` removes _a lot_ of allocations per `Opt` in the parser. Args are not copied around much, but changing them as well makes it obvious that they do not participate in the ownership. The changes add up to removing ~180 allocations for "empty" invocation of the test binary. (`./tests/ExtraTests/NoTests --allow-running-no-tests -o /dev/null` is down to 317 allocs) 
Because TokenStream is copied around a lot, moving it to use
`StringRef` removes _a lot_ of allocations per `Opt` in the parser.
Args are not copied around much, but changing them as well makes it
obvious that they do not participate in the ownership.

The changes add up to removing ~180 allocations for "empty"
invocation of the test binary.
(`./tests/ExtraTests/NoTests --allow-running-no-tests -o /dev/null`
is down to 317 allocs)
Use StringRef for Opt's optNames 2023-12-26T15:03:22+00:00 Martin Hořeňovský 2023-12-26T13:01:15+00:00 cd3c7ebe873c3da91ce57c6b2221ba95ee7f93e6 Removes another ~70 allocations. 
Removes another ~70 allocations.
Enable moving Opts into Parser 2023-12-26T14:41:07+00:00 Martin Hořeňovský 2023-12-26T10:57:38+00:00 5d5f42f99b7409b6b051182fae69fd22f8877a6d This also required keeping the reference type in the fluent interface for Opts. Removes another ~40 allocations. 
This also required keeping the reference type in the fluent interface
for Opts.

Removes another ~40 allocations.
Avoid copying Clara::Parser for every inserted Opt 2023-12-26T14:11:48+00:00 Martin Hořeňovský 2023-12-26T10:55:19+00:00 c57e349d1d62fcdf96aef576a5c200ae2078daad This prevents the full construction from being O(N^2) in number of `Opt`s, and also reduces the number of allocations for running no tests significantly: `tests/SelfTest`: 7705 -> 6095 `tests/ExtraTests/NoTests` 2215 -> 605 
This prevents the full construction from being O(N^2) in number
of `Opt`s, and also reduces the number of allocations for running
no tests significantly:

`tests/SelfTest`: 7705 -> 6095
`tests/ExtraTests/NoTests` 2215 -> 605