catch3/include/internal/catch_assertionresult.cpp, branch v2.13.7 Progmasoft Catch3: an independently maintained C++17 test framework with a parallel runner, property checks, snapshots and structured results. Remove (mostly) unused overloads of StringRef operator + 2019-09-08T19:01:33+00:00 Martin Hořeňovský 2019-09-08T19:01:33+00:00 9f4c4777a5136a3e1f276398799961e9ccb4b572 






Do not blindly access empty StringRefs
2019-09-08T15:44:56+00:00

Martin Hořeňovský

2019-09-08T15:44:56+00:00

e2b3443fe7211f265c95f878d06d8fd4abf38f27












Make StringRef's operator std::string explicit
2019-09-08T13:58:10+00:00

Martin Hořeňovský

2019-09-08T12:49:40+00:00

7b865daccc7bba2dcc25a4f0b9ea7348b1b4d61f

This way it is explicit when there is a `StringRef` -> `std::string`
conversion and makes it easier to look for allocations that could
be avoided.

Doing this has already removed one allocation per registered test
case, as there was a completely pointless `StringRef` -> `std::string`
conversion when parsing tags of a test case.





This way it is explicit when there is a `StringRef` -> `std::string`
conversion and makes it easier to look for allocations that could
be avoided.

Doing this has already removed one allocation per registered test
case, as there was a completely pointless `StringRef` -> `std::string`
conversion when parsing tags of a test case.







Check for empty expression properly
2019-09-08T12:35:01+00:00

Martin Hořeňovský

2019-09-08T10:17:44+00:00

14362533bb50596049f1b46bcc6d333208576a87

The old code was a left-over from the times when the
`capturedExpression` member was a `const char*`, which could always
be indexed. With the change to use `StringRef`, blindly indexing 0th
element is invalid, as it is not indexable part of a StringRef.





The old code was a left-over from the times when the
`capturedExpression` member was a `const char*`, which could always
be indexed. With the change to use `StringRef`, blindly indexing 0th
element is invalid, as it is not indexable part of a StringRef.







StringRef appends itself to std::string efficiently
2018-02-28T15:02:25+00:00

Martin Hořeňovský

2018-02-28T15:02:25+00:00

950ccf4749dc3324543c0cba44f85ff81dd300af












Remove pointless StringRef -> std::string conversions
2017-11-13T12:08:59+00:00

Martin Hořeňovský

2017-11-13T12:08:59+00:00

a06b6dc3ea58167e8ebd4cb8ebaa1391d6027a4d












Fix pointless type mismatch between StringRef and std::string
2017-11-13T11:49:13+00:00

Martin Hořeňovský

2017-11-13T11:49:13+00:00

f80f28e09aa5ea1d0a981c300d21bfe35c037f55












Introduced ReusableStringStream and removed all uses of std::ostringstream from the main path
2017-11-07T18:01:10+00:00

Phil Nash

2017-11-07T18:01:10+00:00

56e107561362147dc13f63294a9a5b90b855697b

ReusableStringStream holds a std::ostringstream internally, but only exposes the ostream interface.
It caches a pool of ostringstreams in a vector which is currently global, but will be made thread-local.

Altogether this should enable both runtime and compile-time benefits. although more work is needed to realise the compile time opportunities.





ReusableStringStream holds a std::ostringstream internally, but only exposes the ostream interface.
It caches a pool of ostringstreams in a vector which is currently global, but will be made thread-local.

Altogether this should enable both runtime and compile-time benefits. although more work is needed to realise the compile time opportunities.







Fixed expansion of _FALSE binary expression
2017-10-13T18:45:19+00:00

Phil Nash

2017-10-13T18:45:19+00:00

05b1ca28844d2b2770b929415393653474866a3d

- see #1051





- see #1051







Sweep out some extra warnings
2017-09-07T15:25:15+00:00

Martin Hořeňovský

2017-09-07T14:51:33+00:00

9aa96712aec495d5a0d580f773c292803cc662aa

Swept:
`-Wpadded` in some places (where it caused extra size, instead of just
saying "hey, we padded struct at the end to align, just as standard says")
`-Wweak-vtables` everywhere (Clang)
`-Wexit-time-destructors` everywhere (Clang)
`-Wmissing-noreturn` everywhere (Clang)

The last three are enabled for Clang compilation going forward.

Also enabled `-Wunreachable-code` for Clang and GCC





Swept:
`-Wpadded` in some places (where it caused extra size, instead of just
saying "hey, we padded struct at the end to align, just as standard says")
`-Wweak-vtables` everywhere (Clang)
`-Wexit-time-destructors` everywhere (Clang)
`-Wmissing-noreturn` everywhere (Clang)

The last three are enabled for Clang compilation going forward.

Also enabled `-Wunreachable-code` for Clang and GCC