catch3, branch v2.12.2

v2.12.2

2020-05-25T13:13:18+00:00

Really fix use of std::result_of when invoke_result is available

2020-05-22T08:05:34+00:00

Closes #1934

Avoid using std::result_of when std::invoke_result is available

2020-05-21T19:39:19+00:00

Closes #1934

Remove obsolete comment in UnorderedEquals vector matcher

2020-05-18T12:29:50+00:00

Create a BUILD file for compatibility with bazel

2020-05-17T11:18:22+00:00

With this change, it's much easier for bazel projects to depend on
Catch. They just need to add:
  - In the workspace:
  ```
http_archive(
    name = "com_github_catchorg_catch2",
    urls = ["https://github.com/catchorg/Catch2/archive/v2.12.1.tar.gz"],
    strip_prefix = "Catch2-2.12.1",
    sha256 = "e5635c082282ea518a8dd7ee89796c8026af8ea9068cd7402fb1615deacd91c3",
)
```
  Or the appropriate version/sha256.
  - For the tests, assuming that `test_main.cc` contains the
  `CATCH_CONFIG_MAIN`:
  ```
cc_library(
    name = "test_main",
    srcs = ["test_main.cc"],
    deps = ["@com_github_catchorg_catch2//:catch2"],
)
```

Add status attribute to JUnit's section reporting

2020-05-15T19:00:19+00:00

This brings our output inline with GTest's. We do not handle skipped
tests properly, but that should be currently less important than
having the attribute exist with proper value for non-skipped tests.

Thanks @joda-01.

Closes #1899

Document that user can only provide main in TU with CONFIG_RUNNER

2020-05-15T13:57:27+00:00

Closes #1851

Fix compilation failure when using libstdc++10 (#1929)

2020-05-15T09:30:12+00:00

The issue is caused by deleted `std::__detail::begin` declared in `bits/iterator_concepts.h`. This would be found by ADL, and because it is deleted, compilation would fail. This change makes it so that we SFINAE on `begin(std::declval())` and `end(std::declval())` being well-formed.

Fix invalid isspace call detected by PREfast

2020-05-12T12:07:22+00:00

D:\vcpkg\toolsrc\include\catch2\catch.hpp(11285): warning C6330: 'char' passed as _Param_(1) when 'unsigned char' is required in call to 'isspace'.
D:\vcpkg\toolsrc\include\catch2\catch.hpp(11288): warning C6330: 'char' passed as _Param_(1) when 'unsigned char' is required in call to 'isspace'.

ISO/IEC 9899:2011:
"7.4 Character handling "/1
[...] In all cases the argument is an int, the value of which shall be
representable as an unsigned char or shall equal the value of the macro
EOF. If the argument has any other value, the behavior is undefined.

This means if isspace was passed a character like ñ it could corrupt
memory without the static_cast to treat it as a positive value after
integral promotion (and C libraries commonly use the int index supplied
as a key into a table which result in out of bounds access if the
resulting int is negative).

Silence clang-tidy's hicpp-vararg (alias of coreguidelines vararg)

2020-05-09T16:23:12+00:00

Ideally, clang-tidy would be smart that if one alias of a warning
is suppressed, then the other one is suppressed as well, but as of
right now, it isn't. This means that for now we have to suppress
both aliases of this warning. Opened upstream issue to fix this:
https://bugs.llvm.org/show_bug.cgi?id=45859

Obviously, ideally clang-tidy would also not warn that we are calling
a vararg function when it is an unevaluated magic builtin, but that
also is not happening right now and I opened an issue for it:
https://bugs.llvm.org/show_bug.cgi?id=45860

Closes #1921